This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM Class 4 - Fatemeh Rahimi - JavaScript Core 1 - Week 1#348
Open
FatemRahimi wants to merge 9 commits into
Open
WM Class 4 - Fatemeh Rahimi - JavaScript Core 1 - Week 1#348FatemRahimi wants to merge 9 commits into
FatemRahimi wants to merge 9 commits into
Conversation
szemate
reviewed
Aug 9, 2022
|
|
||
| var totalNumber = numberOfStudents + numberOfMentors; | ||
|
|
||
| var studentPrecentage = (numberOfStudents / totalNumber)* 100; |
| function multiply() { | ||
| function multiply(a , b) { | ||
| let c = a * b; | ||
| return (c); |
| console.log(ShoutGreeting(mentor5)); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Make sure not to leave empty lines at the end of a code file
| outputMessage = "positive"; | ||
| } else if (negativeList.includes(answer)) { | ||
| outputMessage = "negative"; | ||
| } else { |
There was a problem hiding this comment.
What happens if the value of answer is not in the veryNegativeList? I think it would be better to make sure it is included:
} else if (veryNegativeList.includes(answer)) {
outputMessage = "very negative";
} else {
outputMessage = "error";
}or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
excersie tasks
What did you find hard?
mandatory tasks and testing
What do you still not understand?
Any other notes?