South Africa_Class-1 - Douglas Van Der Merwe - JavaScript Core - 1 by DouglasVDM · Pull Request #40 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

DouglasVDM · 2021-01-20T20:53:38Z

Your Details

Your Name: Douglas Van Der Merwe
Your City: Cape Town
Your Slack Name: Douglas Van Der Merwe

Homework Details

Module: JavaScript - Core
Week: 1

when you get rid of the quote marks you get some kinf of error and when you console log a number without quotes the number still appears

greeting

d strings

strings concatenation

syntax error completed 1

logic errors done

completed

Mt first try.

concatenation with interpolation.

Added function for message.

Denver and Andile google meets

Denver and Andile

…e-1-Coursework-Week1

Jontas77 · 2021-01-21T18:38:09Z


 // Add comments to explain what this function does. You're meant to use Google!
+// The concat() method is used to join two or more arrays.
+This method does not change the existing arrays, but returns a new array, containing the values of the joined arrays.


Hi Douglas great work buddy, you forgot to add slashes to make line 12 a comment.

Thank you Jontaz77 for your comment. I'll review it and make the necessary changes.

Jontas77 · 2021-01-21T19:36:47Z

+
+let answer = divide(5, 10);
+
+console.log(Math.round(answer));


Douglas the expected results show 0.75 in the instructions and I see you using Math.round?

Thank you Jontaz77 for your comment. I'll review it and make the necessary changes.

Jontas77 · 2021-01-21T19:48:54Z

Hi Douglas you have done great work, keep it up buddy. Just my opinion your code has a lot of comments and is sometimes confusing to read your code.

sirpfaira · 2021-01-21T23:24:55Z

 // Add comments to explain what this function does. You're meant to use Google!
 // The concat() method is used to join two or more arrays.
-This method does not change the existing arrays, but returns a new array, containing the values of the joined arrays.
+// This method does not change the existing arrays, but returns a new array, containing the values of the joined arrays.


I think the proper definition should have been , "the method is used to join two or more strings." because the test cases passes strings not arrays. I know the method also works for arrays but since also we haven't done arrays as yet....

Thank you Simba for your comment. I'll review it and make the necessary changes.

sirpfaira · 2021-01-21T23:26:29Z

 function multiply(a, b, c) {
-  a * b * c;
-  return;
+      return a*b*c;


what happened to the original spacing between a,b,c

Thank you Simba for your comment. I'll review it and make the necessary changes.

MSUMBA-art · 2021-01-22T21:54:47Z

I looked at your homework, looks great, thanks for the help

dschouw · 2021-03-22T15:46:56Z

Javascript Core 1 - Week 1 Feedback

Well done on completing the homework Douglas!
I've added some comments below and marked this assignment as Returned on Google Classroom.
Please feel free to reach out to me on Slack or Email if anything is unclear.

Git Status

Total Commits : 28

Exercises Comments

Issue J-functions/Exercise2.js
The function threeTimes(number) appears to be tripling and then tripling the number again.
Have a look at the calculation in the function and try and test it and match the result against your expected output.
Issue extra/2-piping.js

Allocating a variable and attempting to use it in a function call at the same time seems to be raising an error.
```
const startingValue = format(multiply((add(startingValue, 10), 2)));
```
The startingValue variable cannot be passed to a function before it is initialized.

Mandatory Homework Comments

Excellent job on the exercises and mandatory homework. Good use of functions, their paramters and your use of the let and const keywords

Links

github-actions · 2021-05-13T13:17:49Z

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

AbdulqadirAbdillahi and others added 30 commits December 14, 2020 16:47

B done

8dc67a8

when you get rid of the quote marks you get some kinf of error and when you console log a number without quotes the number still appears

C

fe52111

greeting

exercide d

fbd526d

d strings

e exercise

7b792b0

strings concatenation

answers f to k

ea1271e

Update exercise.js

1da95c7

Update 1-syntax-errors.js

11dd1d9

syntax error completed 1

Update 2-logic-error.js

1ba5862

logic errors done

Update 3-function-output.js

e2962b6

completed

Update 4-tax.js

78a1327

Update 1-syntax-errors.js

ef5eef6

Mt first try.

Add comments after google search

d705ed0

Add comments to changes

6abe75e

C-variables

c249f4d

Exercise-D

d32cd9e

E-Strings-Concatenation

536905c

F-strings-methods

88f9484

concatenation with interpolation.

F-strings-methods-exercise2

566951e

G-numbers

40591b2

I-floats-exercise

3a15ad7

J-functions-exercise.js

19b9c40

J-functions-exercise2

87245d1

K-functions-parameters-exercise1

5d42014

K-functions-parameters-exercise2

b9bfb6e

K-functions-parameters-exercise3

75d4e88

K-functions-parameters-exercise4

e6de8c0

K-functions-parameters-exercise5

85c3407

L-functions-nested-exercise1

b895d6e

L-functions-nested-exercise1-add %

38b2718

L-functions-nested-exercise1-add function for message

7340001

Added function for message.

DouglasVDM added 9 commits January 18, 2021 14:04

L-functions-nested-exercise2

cdb6a42

mandatory-3-function-output

84755e7

Mandatory-4-tax-meet

d0a1842

Denver and Andile google meets

L-functions-exercise-meet

2b62668

Denver and Andile

1-currency-conversion

0573375

extra-2-piping

b04fffd

mandatory-4-tax-cleanup

e363d53

extra-2-piping

8e49331

Merge branch 'master' of https://github.com/DouglasVDM/JavaScript-Cor…

20b1ff6

…e-1-Coursework-Week1

Jontas77 reviewed Jan 21, 2021

View reviewed changes

sirpfaira reviewed Jan 21, 2021

View reviewed changes

github-actions Bot added the Stale label May 13, 2021

github-actions Bot closed this May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

South Africa_Class-1 - Douglas Van Der Merwe - JavaScript Core - 1#40

South Africa_Class-1 - Douglas Van Der Merwe - JavaScript Core - 1#40
DouglasVDM wants to merge 39 commits into
CodeYourFuture:masterfrom
DouglasVDM:master

DouglasVDM commented Jan 20, 2021

Uh oh!

Jontas77 Jan 21, 2021

Uh oh!

DouglasVDM Jan 22, 2021 •

edited

Loading

Uh oh!

Jontas77 Jan 21, 2021

Uh oh!

DouglasVDM Jan 22, 2021

Uh oh!

Jontas77 commented Jan 21, 2021

Uh oh!

sirpfaira Jan 21, 2021

Uh oh!

DouglasVDM Jan 22, 2021 •

edited

Loading

Uh oh!

sirpfaira Jan 21, 2021

Uh oh!

DouglasVDM Jan 22, 2021 •

edited

Loading

Uh oh!

MSUMBA-art commented Jan 22, 2021

Uh oh!

dschouw commented Mar 22, 2021

Uh oh!

github-actions Bot commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		let answer = divide(5, 10);

		console.log(Math.round(answer)); No newline at end of file

Uh oh!

Conversation

DouglasVDM commented Jan 20, 2021

Your Details

Homework Details

Uh oh!

Jontas77 Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

DouglasVDM Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jontas77 Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

DouglasVDM Jan 22, 2021

Choose a reason for hiding this comment

Uh oh!

Jontas77 commented Jan 21, 2021

Uh oh!

sirpfaira Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

DouglasVDM Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sirpfaira Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

DouglasVDM Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MSUMBA-art commented Jan 22, 2021

Uh oh!

dschouw commented Mar 22, 2021

Javascript Core 1 - Week 1 Feedback

Git Status

Exercises Comments

Mandatory Homework Comments

Links

Uh oh!

github-actions Bot commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DouglasVDM Jan 22, 2021 •

edited

Loading

DouglasVDM Jan 22, 2021 •

edited

Loading

DouglasVDM Jan 22, 2021 •

edited

Loading