London-10-Afsha-Hossain-JavaScript-core-1-coursework-week1 by Afsha10 · Pull Request #503 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

Afsha10 · 2023-02-20T13:15:21Z

Completed the mandatory part and most of extras . Need help in the last task in extra.

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name:
Your City:
Your Slack Name:

Homework Details

Module:
Week:

Notes

What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?

Completed the mandatory part and most of extras . Need help in the last task in extra.

JarrodFolinoFC · 2023-02-20T17:00:22Z


-function calculateSalesTax() {}
+function calculateSalesTax(price) {
+  return 1.20 * price;


this can just be 1.2

JarrodFolinoFC · 2023-02-20T17:01:13Z

+];
+
+function checkAnswer() {
+  if answer = "It is certain." || "It is decidedly so." || "Without a doubt." || "Yes - definitely." || "You may rely on it." {


What is the difference between = and ===

maxbmaapc · 2023-02-20T17:16:17Z

+];
+
+function checkAnswer() {
+  if answer = "It is certain." || "It is decidedly so." || "Without a doubt." || "Yes - definitely." || "You may rely on it." {


check syntax of if loop. ex.

If (condition) {
return something
} if else (condition) {
return something
} else {
return
};

maxbmaapc · 2023-02-20T17:18:09Z

 */
-function checkAnswer(answer) {
+
+const answer = [


My advice, break answers array into four arrays with relevant name (arr positive[answers], negative[answers] and so on) and then join them into one using spread operator.

maxbmaapc · 2023-02-20T17:21:59Z

+    "Very doubtful."
+];
+
+function checkAnswer() {


in this function you need to compare each answer with location in certain array. But in your loop you compare the array itself with the possible answer, so it's not gonna work.

maxbmaapc · 2023-02-20T17:25:49Z

+  answerRandom = Math.floor(Math.random() * 16);
+  return answerRandom;


Suggested change

answerRandom = Math.floor(Math.random() * 16);

return answerRandom;

answerRandom = allAnswers[Math.floor(Math.random() * allAnswers.length)];

return answerRandom;

Here you get answerRandom from your array

use console.log to meet the condition of one of comments This should log "The ball has shaken!"

maxbmaapc · 2023-02-20T17:27:44Z

+    "It is certain.",
+    "It is decidedly so.",
+    "Without a doubt.",
+    "Yes - definitely.",
+    "You may rely on it.",


Suggested change

"It is certain.",

"It is decidedly so.",

"Without a doubt.",

"Yes - definitely.",

"You may rely on it.",

const veryPositive = [ "It is certain.",

"It is decidedly so.",

"Without a doubt.",

"Yes - definitely.",

"You may rely on it.",

]

This is as an example of a child array

maxbmaapc · 2023-02-20T17:29:02Z

+    "Outlook not so good.",
+    "Very doubtful."
+];
+


Suggested change

const allAnswers = [...veryPositive, ...positive, ans so on]

check how works spread operator

maxbmaapc · 2023-02-20T17:32:00Z

+  if answer = "It is certain." || "It is decidedly so." || "Without a doubt." || "Yes - definitely." || "You may rely on it." {
+    return "The answer is very positive: ${randomAnswer}";


Suggested change

if answer = "It is certain." || "It is decidedly so." || "Without a doubt." || "Yes - definitely." || "You may rely on it." {

return "The answer is very positive: ${randomAnswer}";

if (veryPositive.includes(answer)) {

return "very positive"

} if else (positive.includes(answer)) {

return ....

you can continue yourself
I hope it's helpful. if you get stuck, write me in slack, or check my PR

SeyoungJoo · 2023-02-24T20:50:35Z


-function convertToBRL() {}
+function convertToBRL(price) {
+  price = price * 0.99 * 5.7;


when declaring a variable, must use const or let, otherwise it becomes a global variable which can cause a bug.

the variable name and parameter name should be different :)

SeyoungJoo · 2023-02-24T20:53:39Z

-let goodCode =
+const betterStartingValue = 2;
+additionResult = betterStartingValue + 10;
+multiplicationResult = additionResult * 2;


let's use const 🚀

const additionResult = betterStartingValue + 10;
const multiplicationResult = additionResult * 2;

…a few corrections based on the reviewers comments.

Completed the mandatory part and most of extras

091370b

Completed the mandatory part and most of extras . Need help in the last task in extra.

Afsha10 changed the title ~~Completed the mandatory part and most of extras~~ London-10-Afsha-Hossain-JavaScript-core-1-coursework-week1 Feb 20, 2023

Elenar9 reviewed Feb 20, 2023

View reviewed changes

Comment thread mandatory/1-syntax-errors.js

Comment thread mandatory/1-syntax-errors.js

Comment thread mandatory/2-logic-error.js

JarrodFolinoFC reviewed Feb 20, 2023

View reviewed changes

maxbmaapc reviewed Feb 20, 2023

View reviewed changes

Made some changes to the mandatory and extra sections

3525582

SeyoungJoo reviewed Feb 24, 2023

View reviewed changes

Afsha10 added 2 commits February 24, 2023 23:18

Made some changes to variable names for better review

6c324c5

COrrected Magic ball

03ad6b1

moneyinthesky added the reviewed label Mar 4, 2023

Made some changes, added some comments for my understanding and made …

8a7c77a

…a few corrections based on the reviewers comments.

		answerRandom = Math.floor(Math.random() * 16);
		return answerRandom;


	const allAnswers = [...veryPositive, ...positive, ans so on]

		if answer = "It is certain." \|\| "It is decidedly so." \|\| "Without a doubt." \|\| "Yes - definitely." \|\| "You may rely on it." {
		return "The answer is very positive: ${randomAnswer}";

-  if answer = "It is certain." || "It is decidedly so." || "Without a doubt." || "Yes - definitely." || "You may rely on it." {
-    return "The answer is very positive: ${randomAnswer}";
+if (veryPositive.includes(answer)) {
+return "very positive"
+} if else (positive.includes(answer)) {
+ return ....

Uh oh!

Conversation

Afsha10 commented Feb 20, 2023

Your Details

Homework Details

Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxbmaapc Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxbmaapc Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SeyoungJoo Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SeyoungJoo Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

maxbmaapc Feb 20, 2023 •

edited

Loading

maxbmaapc Feb 20, 2023 •

edited

Loading

SeyoungJoo Feb 24, 2023 •

edited

Loading

SeyoungJoo Feb 24, 2023 •

edited

Loading