This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 10/Eagles - Danny Romero - JavaScript-Core-1-Coursework-Week1 #511
Open
Elenar9 wants to merge 4 commits into
Open
London Class 10/Eagles - Danny Romero - JavaScript-Core-1-Coursework-Week1 #511Elenar9 wants to merge 4 commits into
Elenar9 wants to merge 4 commits into
Conversation
Ali-Jahankah
reviewed
Mar 4, 2023
| let total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return `The total is 28`; |
There was a problem hiding this comment.
Hi Danny, Good job! Here 28 is a static value. You need to make it dynamic by returning :
return The total is ${total}
Ali-Jahankah
reviewed
Mar 4, 2023
| expect(introduceMe("Sonjide", 27)).toEqual( | ||
| "Hello, my name is Sonjide and I am 27 years old" | ||
| expect(introduceMe("Sonjide", 28)).toEqual( | ||
| "Hello, my name is Sonjide and I am 28 years old" |
There was a problem hiding this comment.
Hi Danny, in exercies, you don't need to change the tests scripts. If your function is written correctly, the tests functions test them by sending some random inputs and you can see if your function is written correct or not. :)
Ali-Jahankah
reviewed
Mar 4, 2023
|
|
||
| =================================================== | ||
| ======= TESTS - DO NOT MODIFY BELOW THIS LINE ===== | ||
|
|
There was a problem hiding this comment.
Hi Danny, please try to add comments for thhis tasks if you get some free time. You can google it or use MDN website as well. Thanks
Ali-Jahankah
reviewed
Mar 4, 2023
| } | ||
|
|
||
| /* | ||
| =================================================== |
Ali-Jahankah
reviewed
Mar 4, 2023
Ali-Jahankah
left a comment
Ali-Jahankah
left a comment
There was a problem hiding this comment.
Please have a look at my single comments. Thanks! Keep going!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? mandatory/extra exercises are intended to be run as jest tests.
What did you find hard? exercise 4 apply the functions
What do you still not understand?
Any other notes?