London Class 7 - Hozan Ali - JavaScript-Core-2-Coursework-Week1 by Hozan94 · Pull Request #50 · CodeYourFuture/JavaScript-Core-2-Coursework-Week1-Archived

Hozan94 · 2021-02-21T01:56:28Z

Your Details

Your Name: Hozan Ali
Your City: London
Your Slack Name: Hozan Ali

Homework Details

Module: JavaScript-Core-2-Coursework
Week: Week 1

louisechow · 2021-02-21T12:21:47Z


+const { WriteStream } = require("fs");
+
 // We've created an array of objects for you here:


Not sure how line 22 got added. You don't need it.

louisechow · 2021-02-21T12:25:20Z

+writers.filter(writer => writer.age >= 40 && writer.age <= 49 && writer.alive == false).forEach(writer => {
+  console.log(`Writer ${writer.firstName} ${writer.lastName} died at ${writer.age} years old.`)
+});
 /*


Great use of the method chaining with the filter and forEach functions for exercise 2 and 3! 👏

louisechow · 2021-02-21T12:48:00Z

  },
  pour: function () {
    // calling this function should increase your bottle volume by 10 units;
+    if (this.volume < 100) {


This works! Another way you could have done the condition is to just check if the bottle was full already

if (!this.isFull()) { // do stuff here }

Similar for the drink function, you could check if it was empty before drinking.

@louisechow That is really interesting to know , that you can have a method as a condition and that they are also hoisted

louisechow · 2021-02-21T13:03:56Z

 Extra question:
  Why do you think it is preferred to use `this` inside the object rather than its variable name, in our case `bottle`?
  Leave your answer below:
+


Good answer!

louisechow · 2021-02-21T13:35:22Z

+let groceriesListWithNoRepeatingItems = groceriesList.filter((item, index) => groceriesList.indexOf(item) === index);
+groceriesListWithNoRepeatingItems.forEach(item => weeklyGroceriesToBuy.push(item));
+console.log(weeklyGroceriesToBuy);
 /*


This is a really interesting way you've solved the problem, particularly line 33. The question did ask you to do it using looping, but you can maybe try that method another time as a challenge.

Two things to point out with your solution:

You have an empty item in your result, you should try to filter that out too.

[ 'Cheese', 'Eggs', 'Tomato', 'Paprika', 'Leek', 'Wrap', 'Tuna', 'Canned beans', 'Carrot', 'Aubergine', 'Orange Juice', 'Apple', 'Ananas', 'Black tea', 'Lamb', 'Salt', 'Bulgur', 'Potato', 'Rice milk', 'Blueberries', 'Porridge', 'Banana', 'Cinnamon', 'Olive oil', 'Salmon', 'Asparagus', '' ]

Line 35 isn't really doing anything for you other than putting what's in groceriesListWithNoRepeatingItems into weeklyGroceriesToBuy. Why not just assign directly the result to weeklyGroceriesToBuy in line 34. You could leave a comment above the line if you wanted to explain that you are removing duplicates.
E.g.

// Filter out duplicate items weeklyGroceriesToBuy = groceriesList.filter((item, index) => groceriesList.indexOf(item) === index);

@louisechow regarding your second point, you are right that is alot more readable and shorter. And for the first point I will look into that as well.

louisechow · 2021-02-21T13:38:47Z

+}
+console.log(numberOfItemsPerWeek);
+
+


Some extra code here that isn't related to the exercise and should be removed 🤔

louisechow · 2021-02-21T13:52:22Z


-let thirtyFiveOrOlder = [];
+let thirtyFiveOrOlder = people.filter(friend => friend.age >= 35);



louisechow · 2021-02-21T13:58:01Z

-let powerNetEmails = [];
+// // Method 1
+let powerNetEmails = people.filter(friend => friend.company === "POWERNET").map(friend => friend.email).reverse();
+


This answer is fine. I think you should pick the method you think is the best Hozan and just submit that, no need to list every possible method you could use.

Why did you reverse your array though? (Why are all the trainees reversing their arrays 🤔 )

Edit ohhhh I see, because the test check for a certain order. Ok nevermind then, i'll get them to fix the test.

@louisechow I just wanted to experiment different methods, I know it makes the code harder to read, but If I have them somewehre else I will forget I had them, that's why I write them here. sorry for the inconvenience.

louisechow · 2021-02-21T14:32:20Z

+  }
+}
+friendsWithStacie.reverse();
 /*


This works!

You could also do this by making use of the filter function to check whether someone is a friend with Stacie.

people .filter(function isFriendsWithStacie(person) { // Check if someone is a friend with Stacie })

What line would you put in the function to check if Stacie is in the list of that person's friends? Hint: Do you know any array methods can can be used to find a particular element in an array?

@louisechow

let friendsWithStacie = people.filter(function isFriendsWithStacie(person) { return person.friends.some(personDetail => personDetail.name.includes("Stacie Villarreal")) }).map(friend => `${friend.name.first} ${friend.name.last}`)

I know I had to use the "includes" method, but could not figure out how to access the elements in "friends" arrays that are objects, so finally came up with some() method, Now I figured it out, does that mean the includes method here works more as the string method rather than an array method, because personDetail.name is an object property and not an array element. please correct me If I am wrong.

louisechow · 2021-02-21T15:10:08Z

+    }
+  }
+}
 /*


This works!

If you'd like a challenge, another way to do this would be to use array methods you have learnt before. Try for yourself.

Get the friend list for each of your friends (map)

For each list of friends (forEach), return the list of people who can multi-task (filter)

Add their name to your array friendsWhoCanMultitask (map)

@louisechow I tried step 1 and 2 so far but I get "undefined"

people.map(personFriends => personFriends.friends).forEach(friendList => friendList.filter(person => person.skills.includes("Multi-tasking")))

Does not forEach always returns undefined?

louisechow · 2021-02-21T15:24:31Z

 **/

-let recipes = {};
+let recipes = {


I would recommend you use an Array to store a list rather than an object.

let recipes = [ { title: "Dough", serves: 4, ingredients: ["flour", "water", "sugar", "salt"] }, etc... ]

@louisechow I followed what I was asked here in question by saying to create an object, unless they meant the elements of an array to be objects. If that is the case sorry for misunderstanding

louisechow · 2021-02-21T15:28:31Z

+        Ingredients: ["tomato", "cucumber", "oil", "salt", "parsley", "cumin"]
+    }
+};
+


This is fine given you defined it as an object rather than an array.

This is why I suggest you always use an array for a list. If you defined it as an array then you could more easily iterate over it just using for...of...

louisechow · 2021-02-21T15:31:33Z

+});
+
+books.forEach(book => {
+    console.log(book.title === 1984 ? `You've already read ${book.title} by ${book.author}` : `You still need to read ${book.title} by ${book.author}.`)


It would have been easier for yourself if you added a property on your object that indicated whether you had read it or not. Then you could check the property as you looped through.

@louisechow I was actually tempted to add a property with a boolean value, but then decided to go with this method as they question did not specify what to use.

louisechow · 2021-02-21T15:35:34Z

+function getBudgets(peopleArray) {
+
+  for (let person of peopleArray) {
+    let sum = 0;


Careful here, you are resetting the sum to be 0 each time you loop. I don't think that's what you want. Where should you move line 22 to?

@louisechow you are right I had it by mistake inside the loop, It should be before the loop on line 20

louisechow · 2021-02-21T15:42:34Z

+
 function chooseMeal(mealArray) {
-  // Write your code here
+  if (mealArray.length >= 2) {


There's a way for you to consolidate lines 40 - 44.
You don't need to create the new array for just the prices. You can use the dot notation to access the price from meal object when you are comparing them.

mealArray.sort((mealA, mealB) => mealA.price - mealB.price);

Now you have a sorted array of meals and you can just use indexes to pick out the cheapest, second cheapest etc.

louisechow · 2021-02-21T15:48:39Z

Great job with the homework this week Hozan! 👏

There were a few questions where you answered them in very creative ways. If you have time to practise, I'd recommend going back and try to solve them with some of the suggestions I made.

Let me know if you need me to explain anything.

github-actions · 2021-05-14T01:59:51Z

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

Hozan94 added 3 commits February 20, 2021 03:17

Completed 1-5

43b46a2

adding the remaining questions

ea5135e

changed the names of variables

c7cbd74

louisechow reviewed Feb 21, 2021

View reviewed changes

louisechow added the reviewed A mentor has reviewed this code label Feb 21, 2021

update after a review from PE

760d431

github-actions Bot added the Stale label May 14, 2021

github-actions Bot closed this May 14, 2021


		const { WriteStream } = require("fs");

		// We've created an array of objects for you here:


		let thirtyFiveOrOlder = [];
		let thirtyFiveOrOlder = people.filter(friend => friend.age >= 35);

		}
		console.log(numberOfItemsPerWeek);

Uh oh!

Conversation

Hozan94 commented Feb 21, 2021

Your Details

Homework Details

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louisechow Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louisechow Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louisechow Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louisechow commented Feb 21, 2021

Uh oh!

github-actions Bot commented May 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

louisechow Feb 21, 2021 •

edited

Loading

louisechow Feb 21, 2021 •

edited

Loading

louisechow Feb 21, 2021 •

edited

Loading