This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM4-MICHEALE-ANDEMARIAM-JAVASCRIPT-CORE-2-COURSEWORK-WEEK1#104
Open
micheale2021 wants to merge 10 commits into
Open
WM4-MICHEALE-ANDEMARIAM-JAVASCRIPT-CORE-2-COURSEWORK-WEEK1#104micheale2021 wants to merge 10 commits into
micheale2021 wants to merge 10 commits into
Conversation
DomVinyard
reviewed
Sep 25, 2022
|
|
||
| console.log(favoriteRecipes.Title); | ||
| console.log(`Serves: ${favoriteRecipes.Serves}`); | ||
| console.log(`Ingredients: ${favoriteRecipes.Ingredients}`); |
There was a problem hiding this comment.
Suggested change
| console.log(`Ingredients: ${favoriteRecipes.Ingredients}`); | |
| console.log(`Ingredients: ${favoriteRecipes.Ingredients.split('\n')}`); |
DomVinyard
reviewed
Sep 25, 2022
Comment on lines
+22
to
+29
| let missingItems = recipe.ingredients.filter((item)=> { | ||
|
|
||
| return !pantry.fridgeContents.includes(item) && !pantry.cupboardContents.includes(item) | ||
|
|
||
| }); | ||
| return { | ||
| name : recipe.name, | ||
| items : missingItems, |
There was a problem hiding this comment.
Suggested change
| let missingItems = recipe.ingredients.filter((item)=> { | |
| return !pantry.fridgeContents.includes(item) && !pantry.cupboardContents.includes(item) | |
| }); | |
| return { | |
| name : recipe.name, | |
| items : missingItems, | |
| let missingItems = recipe.ingredients.filter((item)=> { | |
| const isInFridge = pantry.fridgeContents.includes(item) | |
| const isInCupboard = pantry.cupboardContents.includes(item) | |
| return !isInFridge && !isInCupboard | |
| }); | |
| return { | |
| name : recipe.name, | |
| items : missingItems, |
DomVinyard
reviewed
Sep 25, 2022
| // write code here | ||
| orderBurger: function(balance){ | ||
| if(balance >= MENU.burger){ | ||
| return MENU.burger - balance |
There was a problem hiding this comment.
Suggested change
| return MENU.burger - balance | |
| return balance - MENU.burger |
DomVinyard
reviewed
Sep 25, 2022
| }, | ||
| orderFalafel: function(balance){ | ||
| if(balance >= MENU.falafel){ | ||
| return MENU.falafel - balance |
There was a problem hiding this comment.
Suggested change
| return MENU.falafel - balance | |
| return balance - MENU.falafel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?