This repository was archived by the owner on Jan 14, 2024. It is now read-only.
LONDON-9-LAVELACE-BOSHRA-MAHMOUDI-JS-CORE2-WEEK1#169
Open
BoshraM wants to merge 3 commits into
Open
Conversation
ellietms
reviewed
Dec 30, 2022
|
|
||
| topPlayers=basketballTeam.topPlayers.sort().join("\n") | ||
| console.log(topPlayers) | ||
|
|
Member
There was a problem hiding this comment.
good job Bushra :), I think here we wanted you to show each top player, instead of showing the array :) , Like this :
basketballTeam.topPlayers.sort().forEach/map(player => console.log(player))
Author
There was a problem hiding this comment.
thank you for review my home work , yes you are right . I've fiexed
| if(student.attendence>=90&& student.examScore>60){ | ||
| student.hasPassed=true; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
good job, you should/can have else as well to show false too :)
| @@ -5,19 +5,19 @@ | |||
| */ | |||
Member
There was a problem hiding this comment.
good job, I think you missed mandatory exercises or at least I can not see your solutions , let me know if you have them and want me to review them :)
Author
There was a problem hiding this comment.
yes i havent complete that time my mandatory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?