London9 Lovelace - Oleksii Chepurnyi - JavaScript Core 2 Coursework - Week1#184
London9 Lovelace - Oleksii Chepurnyi - JavaScript Core 2 Coursework - Week1#184OleksChep wants to merge 9 commits into
Conversation
maxf
left a comment
maxf
left a comment
There was a problem hiding this comment.
Excellent. It looks like you're all caught up!
You've also improved your "git hygiene", although you can still improve but not deleting lines randomly, improve your indentation. The "files changed" section in your PR should only show changes related to your solutions to the exercises, not random changes like some whitespace removed.
Congrats!
| */ | ||
| // write code here | ||
| console.log(basketballTeam.topPlayers.sort().join("\n")); | ||
| let basketballTeamsTopPlayers = basketballTeam.topPlayers.sort().join("\n"); |
There was a problem hiding this comment.
Good idea to use a variable to make your code more readable
| }; | ||
|
|
||
| console.log(myPet.getName()); | ||
| // the getName is not a function , getName is property of object myPet |
There was a problem hiding this comment.
That's not correct: getName is a function, and myPet.getName() does call it. The reason why it outputs undefined is elsewhere. I didn't see it at first, either!
| console.log("Recipe 1", " ", recipe1.title); | ||
| console.log("Servings: ", recipe1.servings); | ||
| console.log("Ingredients:", "\n", recipe1.ingredients.join("\n")); | ||
| console.log(`\ `); |
There was a problem hiding this comment.
or perhaps you meant console.log('\n') as a separator?
2 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Add and change properties/
What did you find hard?
In which area of the code to write "if" statement.
What do you still not understand?
Any other notes?