This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM4 - Azin Yadegari - JavaScript -Core2-Week1#92
Open
AzinYad wants to merge 6 commits into
Open
Conversation
jdbevan
reviewed
Sep 27, 2022
jdbevan
left a comment
jdbevan
left a comment
There was a problem hiding this comment.
Great effort, well done formatting the code too!
| // write code here | ||
| let shoppingFor = {}; | ||
| let shoppingList = []; | ||
| // shoppingList= pantryItems.filter(item => !recipe["ingredients"].includes(item)) |
There was a problem hiding this comment.
Well done solving the task! Why comment out these two lines in preference for the for loop?
| let cashRegister = { | ||
| // write code here | ||
| } | ||
| orderBurger(balance) { |
There was a problem hiding this comment.
This is great :) Can you think of a way to avoid duplicating the price of the burger and falafel? Can you think of a reason we'd want to avoid duplicating the price all over the code?
| console.log(str); | ||
| str.forEach((word) => { | ||
| if (word === "") { | ||
| return wordCount; |
There was a problem hiding this comment.
Nice job! What is the purpose of this line of code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
extra was a bit challenging
What do you still not understand?
Any other notes?