Glasgow | Sheetal Kharab | Module-Complexity | Sprint 2 | Improve code with precomputing by sheetalkharab · Pull Request #41 · CodeYourFuture/Module-Complexity

sheetalkharab · 2025-10-16T19:58:02Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

change for common_prefix and count_letters file and This PR includes the improvements for Sprint 2: precomputing optimizations in the following files:
Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py
Sprint-2/improve_with_precomputing/count_letters/count_letters.py
All unrelated files and folders from Sprint 1 have been removed from this PR to ensure a clean and focused review.

Questions

no

github-actions · 2026-01-26T17:39:49Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-01-26T17:39:53Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

OracPrime

One typo worth quickly correcting in the otherwise good Sprint 2 work. You need to remove the Sprint 1 files

OracPrime · 2026-01-26T17:41:02Z

Sprint-2/improve_with_precomputing/count_letters/count_letters.py

+    #             only_upper.add(letter)
+    # return len(only_upper)
+    uppercase_letters : Set[str] = set()
+    lowecase_letters : Set[str] = set()


typo in name

i change it. Thank you

OracPrime · 2026-01-26T17:41:25Z

Sprint-2/improve_with_precomputing/count_letters/count_letters.py

-                only_upper.add(letter)
-    return len(only_upper)
+            uppercase_letters.add(letter)
+        elif letter.isalpha():


Nice - picking up the non-letter case

@OracPrime please review it. sorry for delay

github-actions · 2026-01-26T17:42:40Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-01-26T17:42:43Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-18T21:10:05Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-18T21:26:35Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_precomputing/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

OracPrime · 2026-02-18T22:26:10Z

The sprint 1 files are still here, which is failing the github-actions check... and my check!

sheetalkharab · 2026-02-19T11:16:58Z

@OracPrime I removed them as you suggested Thank you.

github-actions · 2026-02-19T11:17:24Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

OracPrime

You need to remove the folders as well - same technique: delete locally and commit and push

github-actions · 2026-02-19T13:43:07Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T13:45:06Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T13:46:31Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T13:47:12Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-02-19T13:54:30Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

sheetalkharab · 2026-02-19T13:55:00Z

@OracPrime Done as you suggested. Thank you

…lkharab/Module-Complexity into improve_with_precomputing

OracPrime

Github bot is falsely saying Sprint-1 is still there. It's not! So I'm Approving this and closing it.

github-actions · 2026-02-19T14:28:03Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/improve_with_caches/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

OracPrime

Finally there!

sheetalkharab added 6 commits October 14, 2025 20:24

refactor code for calculateSum and product

b2a67d4

refactor code for find commonItems

4aa063a

refactor code for hasPairWithSum

5212626

refactor code for remove duplicate

aad8ad2

improve code for count_letters file

deb4e14

improve code for finding common prefix

3aa1e75

sheetalkharab mentioned this pull request Oct 16, 2025

05 Improve code with precomputing sheetalkharab/My-Coursework-Planner#173

Open

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 16, 2025

OracPrime added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 26, 2026

OracPrime reviewed Jan 26, 2026

View reviewed changes

OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 26, 2026

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

remo typo error

2ee4ae9

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

sheetalkharab mentioned this pull request Feb 19, 2026

Glasgow | Sheetal Kharab | Module-Complexity | Sprint 2 | Improve code with precomputing #115

Open

4 tasks

Remove unwanted Sprint 1 files from PR CodeYourFuture#41

689643f

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

OracPrime suggested changes Feb 19, 2026

View reviewed changes

Remove Sprint-1 folders and files from PR CodeYourFuture#41

456a338

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

sheetalkharab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

sheetalkharab added 3 commits February 19, 2026 14:05

remove sprint 1 folder

bf4ec56

remove sprint 1 folder

c14c15e

Merge branch 'improve_with_precomputing' of https://github.com/sheeta…

6c22643

…lkharab/Module-Complexity into improve_with_precomputing

OracPrime approved these changes Feb 19, 2026

View reviewed changes

OracPrime added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Feb 19, 2026

revert sprint 1 changes

e1f0496

OracPrime approved these changes Feb 19, 2026

View reviewed changes

Uh oh!

Conversation

sheetalkharab commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

OracPrime Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

sheetalkharab Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

OracPrime Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

sheetalkharab Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

sheetalkharab Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

OracPrime commented Feb 18, 2026

Uh oh!

sheetalkharab commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

sheetalkharab commented Feb 19, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

sheetalkharab commented Oct 16, 2025 •

edited

Loading