London | May 2025 | Sisay Mehari | Sprint 2 | Book Library Debugging #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect 'myLibrary' in submit() to ensure new books are added properly.
sisaymehari
added
Needs Review
LonMcGregor
reviewed
Jul 28, 2025
debugging/book-library/script.js
Outdated
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| if (myLibrary[i].check == true) { |
There was a problem hiding this comment.
if .check is a boolean, do you need to compare it to == true?
There was a problem hiding this comment.
We do not need to compare it.
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| alert("Please fill all fields!"); |
There was a problem hiding this comment.
Is there any input validation missing from the pages? What about the author?
There was a problem hiding this comment.
I have done all the input validation.
debugging/book-library/script.js
Outdated
| delButton.className = "btn btn-warning"; | ||
| delButton.innerHTML = "Delete"; | ||
| delButton.addEventListener("click", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); |
There was a problem hiding this comment.
can you think of a better user interaction than alert() here? Deleting something can be pretty bad, and being notified after a delete has happened isnt usually what you see.
There was a problem hiding this comment.
I have added a warning to notify before deleting it.
LonMcGregor
added
Reviewed
sisaymehari
added
the
Needs Review
|
Great work on this -you are done with this task now |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
✅ What I’ve Done
This pull request addresses multiple bugs in the Book Library project:
🔧 Bug Fixes
Books not showing on load
render()afterpopulateStorage()to ensure books display correctly when the page loads.Error in console when adding a book
library.push(...)with the correctmyLibrary.push(...)in thesubmit()function.Title used instead of author
Book()constructor arguments to passauthor.valueinstead of mistakenly usingtitle.valuetwice.No question at the moment.