Skip to content

West Midlands | ITP-25 MAY | Saleh Yousef | Module-Data-Flows | Book Library #266

Closed
SalehOumar wants to merge 3 commits intoCodeYourFuture:mainfrom
SalehOumar:book-library
Closed

West Midlands | ITP-25 MAY | Saleh Yousef | Module-Data-Flows | Book Library #266
SalehOumar wants to merge 3 commits intoCodeYourFuture:mainfrom
SalehOumar:book-library

Conversation

@SalehOumar
Copy link

@SalehOumar SalehOumar commented Aug 4, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@SalehOumar SalehOumar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 4, 2025
cjyuan
cjyuan reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2025
@SalehOumar SalehOumar mentioned this pull request Aug 11, 2025
Open
@SalehOumar
Copy link
Author

SalehOumar commented Aug 11, 2025

Thank you for this feedback it was very helpful.

@SalehOumar SalehOumar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 11, 2025
cjyuan
cjyuan reviewed Aug 11, 2025
View reviewed changes
debugging/book-library/index.html
Copy link
Contributor

@cjyuan cjyuan Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are still errors in the <meta> tag.

debugging/book-library/script.js
Copy link
Contributor

@cjyuan cjyuan Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are syntax errors in this code. The code cannot execute properly.

Copy link
Author

@SalehOumar SalehOumar Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you check now! Thank you

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2025
@SalehOumar SalehOumar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 11, 2025
cjyuan
cjyuan reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Well done.

debugging/book-library/script.js
Comment on lines +54 to +59
function clearForm() {
titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readCheckbox.checked = false;
}
Copy link
Contributor

@cjyuan cjyuan Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also consider calling .reset() of a form node.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SalehOumar @cjyuan @illicitonion