Skip to content

London | 26-ITP-Jan | Asha Ahmed | Sprint 2 | Book Library #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashaahmed7 wants to merge 2 commits into
base: main
Choose a base branch
from
+66 −63
Open

London | 26-ITP-Jan | Asha Ahmed | Sprint 2 | Book Library #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f860ca
Fix HTML structure and improve form input types in index.html
ashaahmed7 Apr 11, 2026
ac8402d
Refactor input validation and improve book submission logic in script.js
ashaahmed7 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +28,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -61,12 +58,9 @@ <h1>Library</h1>
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<button type="button" id="submit-book-btn" class="btn btn-primary">
Submit
</button>
</div>
</div>

Expand All @@ -91,6 +85,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
Copy link
Copy Markdown

@Luro91 Luro91 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this to module? (It is the reason why the app only works in the live server and not if you just open the html file in the browser directly)

</body>
</html>
101 changes: 55 additions & 46 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,64 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
const titleInputEl = document.getElementById("title");
const authorInputEl = document.getElementById("author");
const pagesInputEl = document.getElementById("pages");
const isReadInputEl = document.getElementById("check");
const submitBookBtnEl = document.getElementById("submit-book-btn");
const displayTableEl = document.getElementById("display");

window.addEventListener("load", function () {
populateStorage();
render();
});

submitBookBtnEl.addEventListener("click", submit);

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
if (myLibrary.length === 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
const normalizedTitle = titleInputEl.value.trim();
const normalizedAuthor = authorInputEl.value.trim();
const pagesCount = Number(pagesInputEl.value);

if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
normalizedTitle === "" ||
normalizedAuthor === "" ||
!Number.isInteger(pagesCount) ||
pagesCount <= 0
) {
alert("Please fill all fields!");
alert(
Copy link
Copy Markdown

@Luro91 Luro91 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce error handling

"Please fill all fields correctly. Title and author are required, and page count must be a positive whole number."
);
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(
normalizedTitle,
normalizedAuthor,
pagesCount,
isReadInputEl.checked
);
myLibrary.push(book);
render();

titleInputEl.value = "";
authorInputEl.value = "";
pagesInputEl.value = "";
isReadInputEl.checked = false;
}
}

Expand All @@ -51,53 +70,43 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const tableBodyEl = displayTableEl.tBodies[0];
tableBodyEl.replaceChildren();

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = tableBodyEl.insertRow();
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = String(myLibrary[i].pages);

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
let toggleReadButton = document.createElement("button");
toggleReadButton.className = "btn btn-success";
wasReadCell.appendChild(toggleReadButton);
toggleReadButton.textContent = myLibrary[i].check === false ? "No" : "Yes";

changeBut.addEventListener("click", function () {
toggleReadButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
let deleteButton = document.createElement("button");
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
alert(`You've deleted title: ${deletedTitle}`);
});
}
}
2 changes: 1 addition & 1 deletion debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
Copy link
Copy Markdown

@Luro91 Luro91 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

THe commit messages "Refactor input validation and improve book submission logic in script.js" does not make this clear to me

Copy link
Copy Markdown
Author

@ashaahmed7 ashaahmed7 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked a bit off to me to I decided to change it.

I will be more careful when I commit a file and make sure it doesn't get conflicted with my commit message in the near future, sorry for the confusion.

Copy link
Copy Markdown

@Luro91 Luro91 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It's good practice to split up commits into logical parts and not add all changes in one commit:

A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit

align-self: flex-start;
padding-left: 20px;
}

Expand Down
Loading