Skip to content

Manchester | 26-ITP-Jan | Khalidbih | Sprint 2| Book Library #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khalidbih wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Jan | Khalidbih | Sprint 2| Book Library #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb3788
fix complete book library debugging and HTML validation fixes
khalidbih Apr 19, 2026
8719e9a
use tbody, cleaner DOM rendering, improved text handling
khalidbih Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions debugging/book-library/index.html
View file
Open in desktop
Comment thread
cjyuan marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta charset="utf-8" />
<title> My Book Library </title>

<meta name="viewport" content="width=device-width, initial-scale=1.0" />

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<link rel="stylesheet" href="style.css" />
</head>

<body>
Expand All @@ -31,15 +30,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -62,7 +61,7 @@ <h1>Library</h1>
/>Read
</label>
<input
type="submit"
type="button"
value="Submit"
class="btn btn-primary"
onclick="submit();"
Expand All @@ -80,17 +79,8 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>

<script src="script.js"></script>
</body>
<script src="script.js"></script> </body>
</html>
121 changes: 67 additions & 54 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
let myLibrary = [];
const myLibrary = [];

const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,27 +24,39 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
const trimmedTitle = titleInput.value.trim();
const trimmedAuthor = authorInput.value.trim();

const trimmedPages = Number(pagesInput.value);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name trimmedPages tends to suggest its value is a string.

Copy link
Copy Markdown
Author

@khalidbih khalidbih Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name trimmedPages tends to suggest its value is a string.

Thanks for the feedback, I’ll keep that in mind.


if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
!trimmedTitle ||
!trimmedAuthor ||
!Number.isInteger(trimmedPages) ||
trimmedPages < 1 ||
trimmedPages > 10000
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
alert("Please enter valid book data!");
return;
}
Comment thread
cjyuan marked this conversation as resolved.
const book = new Book(
trimmedTitle,
trimmedAuthor,
trimmedPages,
readCheckbox.checked
);

myLibrary.push(book);

titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readCheckbox.checked = false;

render();
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +67,50 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tbody = document.querySelector("#display tbody");
tbody.innerHTML = "";

for (let i = 0; i < myLibrary.length; i++) {
const row = document.createElement("tr");

const titleCell = document.createElement("td");
const authorCell = document.createElement("td");
const pagesCell = document.createElement("td");
const wasReadCell = document.createElement("td");
const deleteCell = document.createElement("td");

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
changeBut.textContent = myLibrary[i].check ? "yes" : "No";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const delButton = document.createElement("button");
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.textContent = "Delete";
delButton.addEventListener("click", function () {
const deletedBook = myLibrary[i];
myLibrary.splice(i, 1);
render();
alert(`You've deleted title: ${deletedBook.title}`);
});
row.appendChild(titleCell);
row.appendChild(authorCell);
row.appendChild(pagesCell);
row.appendChild(wasReadCell);
row.appendChild(deleteCell);

tbody.appendChild(row);
}
}
Loading