Skip to content

London | ITP-JAN26 | Ihor Taradaiko | Sprint 3 | Alarm Clock#1056

Open
ihortar wants to merge 2 commits intoCodeYourFuture:mainfrom
ihortar:alarm-clock
Open

London | ITP-JAN26 | Ihor Taradaiko | Sprint 3 | Alarm Clock#1056
ihortar wants to merge 2 commits intoCodeYourFuture:mainfrom
ihortar:alarm-clock

Conversation

@ihortar
Copy link
Copy Markdown

@ihortar ihortar commented Mar 20, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Alarm Clock app
including:

  • updated script alarmclock.js
  • updated index.html

@ihortar ihortar added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 20, 2026
@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026
@hkavalikas hkavalikas self-requested a review March 22, 2026 12:03
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if we don't add a value and click on "set alarm", or we add a negative value?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should call the alarm immediately. Will fix to handle it softly.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we click on the set alarm multiple times, we are stacking the timers together, how can we handle it so the timer fully resets?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a variable outside the function, used clearInterval to refresh the alarm

@hkavalikas
Copy link
Copy Markdown

Finally, let's try to add a few more details on the Changelist. The purpose of the changelist is to mention individual updates/additions/changes made for this PR, not so much to add a headline (like the title) of the changes.

@ihortar ihortar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 25, 2026
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants