Skip to content

Birmingham | Jan-ITP-2026 | Arunkumar Akilan | Sprint 3 | Alarm Clock#1096

Open
arunkumarakilan wants to merge 4 commits intoCodeYourFuture:mainfrom
arunkumarakilan:alarmclock/sprint3-clean
Open

Birmingham | Jan-ITP-2026 | Arunkumar Akilan | Sprint 3 | Alarm Clock#1096
arunkumarakilan wants to merge 4 commits intoCodeYourFuture:mainfrom
arunkumarakilan:alarmclock/sprint3-clean

Conversation

@arunkumarakilan
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Implemented countdown timer using setInterval
  • Displayed time in MM:SS format
  • Updated UI every second
  • Played alarm sound when timer reaches 00:00
  • Added stop button to pause alarm and timer
  • Fixed Jest configuration and setup for DOM testing
  • Worked on test cases for countdown behaviour

Questions

  • Is my approach to handling time (minutes and seconds calculation) correct?
  • Is there a cleaner way to structure the updateTime function?
  • Any suggestions to improve readability or reduce repetition?

@arunkumarakilan arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026
@github-actions

This comment has been minimized.

@arunkumarakilan arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026
@jayshreehajgude2012 jayshreehajgude2012 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 25, 2026
Copy link
Copy Markdown

@jayshreehajgude2012 jayshreehajgude2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve readability and apply data validation to improve performance further.

@jayshreehajgude2012 jayshreehajgude2012 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 26, 2026
@arunkumarakilan arunkumarakilan removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Mar 28, 2026
@arunkumarakilan
Copy link
Copy Markdown
Author

Hi 👋

I’ve submitted my PR for Sprint 3 – Alarm Clock App and it has been in Needs Review for more than 2 weeks.

Because it wasn’t reviewed in time, my module submission was marked as incomplete.

I would really appreciate it if someone could review my PR so I can address any feedback and resubmit as soon as possible.

🔗 PR: #1096

Please let me know if anything specific needs to be improved.

Thank you for your support 🙏 @jayshreehajgude2012

Copy link
Copy Markdown

@jayshreehajgude2012 jayshreehajgude2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of setInterval like inbuilt functions and DOM methods.
Nice formatTime() function with padStart() to make code clean.
Efforts put to Separate formatting logic from update logic.

@jayshreehajgude2012 jayshreehajgude2012 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 12, 2026
@arunkumarakilan
Copy link
Copy Markdown
Author

Thank you for your feedback and kind comments! 😊

I’ve addressed all the suggested changes and updated the code accordingly.

Could you please review once more and let me know if anything else is needed, or approve if everything looks good?

Thank you for your support 🙏

@arunkumarakilan arunkumarakilan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 12, 2026
@jayshreehajgude2012 jayshreehajgude2012 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants