Sheffield | 26-Jan-ITP | Martha Ogunbiyi| Sprint 2| Coursework/sprint 2#1133
Open
marthak1 wants to merge 15 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Martha Ogunbiyi| Sprint 2| Coursework/sprint 2#1133marthak1 wants to merge 15 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
the
Needs Review
cjyuan
reviewed
Mar 31, 2026
cjyuan
added
Reviewed
marthak1
added
the
Needs Review
cjyuan
reviewed
Apr 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Just one more question.
| obj === null || | ||
| typeof obj !== "object" || | ||
| Array.isArray(obj) || | ||
| Object.getPrototypeOf(obj) !== Object.prototype |
Contributor
There was a problem hiding this comment.
What is the purpose of the condition on line 6?
Author
There was a problem hiding this comment.
Thanks for feedback. Line 6 ensures the function also reject non plain objects like Map, Set , Date etc.
Contributor
There was a problem hiding this comment.
What about an empty object created from Object.create(null)? Do you plan to reject that kind of object as well?
Note: Prototype is a relatively advanced concept in JS programming. If you have to use it, use it with care.
Author
There was a problem hiding this comment.
Thanks for the feedback, I never thought about about objects created with no prototypes at all on this case. function has now been updated.
cjyuan
removed
the
Needs Review
marthak1
added
the
Needs Review
cjyuan
added
Complete
Contributor
|
All good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 2 coursework done