Skip to content

London | 26-ITP-Jan | Angela McLeary | Sprint 3 | Quote generator app#1138

Open
AngelaMcLeary wants to merge 4 commits intoCodeYourFuture:mainfrom
AngelaMcLeary:Sprint-3/quote-generator-app
Open

London | 26-ITP-Jan | Angela McLeary | Sprint 3 | Quote generator app#1138
AngelaMcLeary wants to merge 4 commits intoCodeYourFuture:mainfrom
AngelaMcLeary:Sprint-3/quote-generator-app

Conversation

@AngelaMcLeary
Copy link
Copy Markdown

@AngelaMcLeary AngelaMcLeary commented Mar 28, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This is a quote generator app.

@github-actions

This comment has been minimized.

Sign in to view
@AngelaMcLeary AngelaMcLeary added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
@AngelaMcLeary AngelaMcLeary added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
Luro91
Luro91 reviewed Apr 6, 2026
View reviewed changes
Comment thread Sprint-3/quote-generator/index.html Outdated
<p id="author"></p>

<button type="button" id="new-quote">New quote</button>
<!-- update styling -->
Copy link
Copy Markdown

@Luro91 Luro91 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this comment?

Copy link
Copy Markdown
Author

@AngelaMcLeary AngelaMcLeary Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luro91. Thank you for your feedback. The reason for the comment was to remind me to update the styling. I will removed it.

Comment thread Sprint-3/quote-generator/quotes.js Outdated

//calls it once so a quote shows immediately on page load
displayNewQuote();
//console.log("checking for random quotes:", pickFromArray(quotes));
Copy link
Copy Markdown

@Luro91 Luro91 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a couple commented out code.
Please check the style guide: https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/

Once you have solved the problem, you should remove large sections of commented out code. When you (or someone else) are reading your code, you want to know only the important pieces. Removing commented out code helps find the relevant code faster and easier.

Copy link
Copy Markdown
Author

@AngelaMcLeary AngelaMcLeary Apr 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luro91, Thank you for your feedback. I have updated the code removing irrelevant comments.

Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment on lines +520 to +521
autoPlayToggle.addEventListener("change", function() {
if (this.checked) {
Copy link
Copy Markdown

@Luro91 Luro91 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation of the stretch goal

Copy link
Copy Markdown
Author

@AngelaMcLeary AngelaMcLeary Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luro91, Thank you for your feedback. I appreciate it.

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 6, 2026
@AngelaMcLeary AngelaMcLeary added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
Luro91
Luro91 reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. The code works as expected and looks much cleaner now

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 6, 2026
@AngelaMcLeary AngelaMcLeary mentioned this pull request Apr 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Luro91 Luro91 Luro91 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AngelaMcLeary @Luro91