Sheffield| 26-ITP-Jan| Mona-Eltantawy | Sprint 2 | Sprint 2 course-work tasks

[Mona-Eltantawy]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

[cjyuan]

Some of the code is not consistently formatted.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?

---

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:

1. Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
2. Edit settings.json and set Prettier as the default formatter for JS.
   See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

[cjyuan]

Consider the following two approaches for determining if an object contains a property:

  let obj = {}, propertyName = "toString";
  console.log( propertyName in obj );                // true
  console.log( Object.hasOwn(obj, propertyName) );   // false

Which of these approaches suits your needs better?
For more info, you can look up JS "in" operator vs Object.hasOwn.

[Mona-Eltantawy]

I understand your point her but the function used still give the required output, so I'm not sure if I have to change it to Object.hasOwn( ) method or to keep it.

[cjyuan]

Have you found out the difference between key in object and Object.hasOwn(object, key)?

As long as you know their differences, you can use either approach in your implementation because the spec is not clear exactly how the function should behave.

[Mona-Eltantawy]

as you said I can use either I kept the key in object in the function implemented already

[cjyuan]

Can you also address the two unaddressed comments from the previous review?

[Mona-Eltantawy]

Some of the code is not consistently formatted.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md ?

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:

1. Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
2. Edit settings.json and set Prettier as the default formatter for JS.
   See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

I already install and use it.

[cjyuan]

Changes look good enough.

Can you address this commenet?
#1195 (comment)

[cjyuan]

You need to join using "\n" if you want each value to appear on a new line.

[Mona-Eltantawy]

do I have to do that If the function implementation already giving the expected output?

[cjyuan]

No need to change. I just need you to take note.

[cjyuan]

Can you address this commenet?
#1195 (comment)

[Mona-Eltantawy]

Can you address this commenet? #1195 (comment)

yeah I did, thank you for re-mention. .

[cjyuan]

All good now.