London | 26-ATP-Jan | Boualem Larbi Djebbour | Sprint 3 | Quote generator#1200
Open
djebsoft wants to merge 14 commits intoCodeYourFuture:mainfrom
Open
London | 26-ATP-Jan | Boualem Larbi Djebbour | Sprint 3 | Quote generator#1200djebsoft wants to merge 14 commits intoCodeYourFuture:mainfrom
djebsoft wants to merge 14 commits intoCodeYourFuture:mainfrom
Conversation
djebsoft
added
the
Needs Review
cjyuan
reviewed
Apr 16, 2026
cjyuan
added
Reviewed
djebsoft
added
Needs Review
cjyuan
reviewed
Apr 16, 2026
cjyuan
added
Reviewed
…r readability, maintenance and future scalability.
…r changes. Lines starting
djebsoft
added
Needs Review
cjyuan
reviewed
Apr 16, 2026
Comment on lines
+1
to
+5
| function setup() { | ||
| const randomQuote = pickFromArray(quotes); | ||
| document.querySelector("#quote").innerText = randomQuote.quote; | ||
| document.querySelector("#author").innerText = randomQuote.author; | ||
| } |
Contributor
There was a problem hiding this comment.
The function name does not quite match the task being performed.
Comment on lines
+6
to
+9
| function newQuote() { | ||
| document.getElementById("new-quote").addEventListener("click", setup); | ||
| } | ||
| newQuote(); |
Contributor
There was a problem hiding this comment.
Statements on lines 7 and 9 are the run-on-load tasks. They are the operations "setup()" should be performing.
cjyuan
added
Reviewed
djebsoft
removed
the
Reviewed
djebsoft
added
the
Needs Review
cjyuan
reviewed
Apr 17, 2026
Comment on lines
+6
to
+10
| function setup() { | ||
| document.getElementById("new-quote").addEventListener("click", randomQuote); | ||
| } | ||
| setup(); | ||
| window.addEventListener("load", randomQuote); |
Contributor
There was a problem hiding this comment.
You can also consider write:
function setup() {
// All tasks to be performed once on page load
document.getElementById("new-quote").addEventListener("click", randomQuote);
randomQuote();
}
// Setup "setup()" to be called on page load
window.addEventListener("load", setup);
Author
There was a problem hiding this comment.
done, thanks for the clarification
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
creating a quote generator application
Questions