Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 2| Coursework by shreefAhmedM · Pull Request #793 · CodeYourFuture/Module-Data-Groups

shreefAhmedM · 2025-10-12T21:28:10Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Her is JavaScript challenges tasks covering running Jest test, error fixing, code interpretation, and a stretch exploration activity.

…perty

…ay of code pairs

…eguency of each items in tally.js file

jaymes15 · 2025-10-25T19:17:35Z

Sprint-2/debug/author.js

+//   console.log(value);
+// }
+// It will log syntax Error because Objects themselves aren’t directly iterable Unlike arrays we need to converted
+// and then we can loop


Very good explanation — you clearly identified why the original loop didn't work and how to resolve it. @shreefAhmedM

jaymes15 · 2025-10-25T19:21:02Z

Sprint-2/debug/recipe.js

+// it will log  [object Object].
+console.log(`${recipe.title} serves ${recipe.serves}`);
+console.log("ingredients");
+recipe.ingredients.forEach((ingredient) => {


Using forEach is a clean and readable way to loop through the ingredients. Good choice.

jaymes15 · 2025-10-25T19:29:55Z

Sprint-2/implement/contains.test.js

 // When passed to contains with a non-existent property name
 // Then it should return false
-
+test("Given an object with none-existing property should return false", () => {


jaymes15 · 2025-10-25T19:36:01Z

Sprint-2/implement/contains.js

-function contains() {}
-
+function contains(obj, prop) {
+  return obj && typeof obj === "object" && prop in obj;


I like that you safeguard against non-object inputs by checking typeof obj === "object". It makes the function more robust and prevents errors when unexpected values are passed in.

jaymes15 · 2025-10-25T19:40:32Z

Sprint-2/debug/address.js

+// is trying to access a property using address[0] and address is an object, not an array.
+// it will log undefined.
+// to access the houseNumber property, we should use dot notation or bracket notation with string,and either
+// way using  object.key or object["key"]


Nice work @shreefAhmedM!
I think we can simplify the comment a bit.

jaymes15 · 2025-10-25T19:41:18Z

Sprint-2/implement/contains.test.js

 // Given invalid parameters like an array
 // When passed to contains
 // Then it should return false or throw an error
+test("Given an object with an existing property should return true", () => {


@shreefAhmedM Good test — small mismatch: the acceptance criteria describe invalid parameters (like an array), but the test title says it's testing an object with an existing property.

jaymes15 · 2025-10-25T19:41:55Z

Sprint-2/implement/contains.js

@@ -1,3 +1,5 @@
-function contains() {}
-
+function contains(obj, prop) {


@shreefAhmedM we can make the argument prop more descriptive

jaymes15 · 2025-10-25T19:45:34Z

Sprint-2/implement/lookup.js

@@ -1,5 +1,15 @@
-function createLookup() {
-  // implementation here
+function createLookup(nestedArr) {


Good job — this works and produces the correct result! 👍
One suggestion: flattening the array isn’t necessary here, since the input is already a 2D array of [country, currency] pairs.
We can make the implementation simpler by iterating directly over each pair and assigning the key-value in the object. This keeps the code readable and avoids potential issues with unexpected nested arrays.

jaymes15 · 2025-10-25T19:46:32Z

Sprint-2/implement/lookup.js

+  return result;
 }
-
+createLookup([


We don’t need to call createLookup here in the module. The tests will call it with the required inputs

jaymes15 · 2025-10-25T20:03:31Z

Sprint-2/implement/tally.test.js

 // Given an array with duplicate items
 // When passed to tally
 // Then it should return counts for each unique item
+test("Given a function tally(['a']), target output should be { a: 1 }", () => {


We can make the test name align with the test requirement

jaymes15 · 2025-10-25T20:04:42Z

Sprint-2/implement/tally.test.js

 // Given an empty array
 // When passed to tally
 // Then it should return an empty object
 test.todo("tally on an empty array returns an empty object");


The test.todo is only a placeholder. Once you implement the real test for an empty array, you can remove this line.

jaymes15 · 2025-10-25T20:05:31Z

Sprint-2/implement/tally.test.js

 // When passed an array of items
 // Then it should return an object containing the count for each unique item
-
+test("Given a function tally(['a']), target output should be { a: 1 }", () => {


The test title and implementation don’t align.

jaymes15 · 2025-10-25T20:13:37Z

Sprint-2/stretch/count-words.js

+function countWords(str) {
+  const obj = {};
+  let tidyStr = str.replace(/[!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~]/g, "");
+  let arr = tidyStr.toLowerCase().split(" ");


Just thinking — splitting by " " only handles regular spaces. It won’t handle tabs (\t) or multiple consecutive spaces correctly. Can we think of a way to handle this?

jaymes15 · 2025-10-25T20:16:07Z

Sprint-2/stretch/mode.js


-  // Find the value with the highest frequency
+// Find the value with the highest frequency
+function highestFreg(freqs) {


@shreefAhmedM Consider renaming highestFreg to highestFreq to fix the typo.

shreefAhmedM added 10 commits October 6, 2025 17:48

Refactor address.js file, accessing value of obj in js

ceb17df

Refactoring author.js file using for loop in obeject

4d1d8ac

debuging recipe.js file

04fa106

refactoring adddress.js file

cd4cb2b

implementing function that checks an object contains a particular pro…

629cd62

…perty

implementing function to lookup object of key value pairs from an arr…

36e36ef

…ay of code pairs

implementing function that takes all a list of items and count the fr…

8bd2a03

…eguency of each items in tally.js file

refactoring and explaining how the invert.js file work

62191e1

refactoring and iterpreting mode.js and till.js files

f324295

sprint-2 exercies has been completed

8fe46af

shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2025

jaymes15 reviewed Oct 25, 2025

View reviewed changes

jaymes15 suggested changes Oct 25, 2025

View reviewed changes

shreefAhmedM added 7 commits November 6, 2025 10:17

updating test file

c995a12

renaming parameter name to be more meaningful

280a02c

deleting an nessessery flattening array

b4e53d0

making the test name align with the test requirement in tally.test file

a3833b1

updating tall.test file

81078b8

updating split to handle multiple consecutive spaces correctly

3aac8f8

fixing spelling mistake highestFreq insted of highestFreg

772e1e0

shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 6, 2025

shreefAhmedM requested a review from jaymes15 November 6, 2025 11:13

jaymes15 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 9, 2025

jaymes15 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 9, 2025

jaymes15 approved these changes Nov 9, 2025

View reviewed changes

shreefAhmedM mentioned this pull request Nov 14, 2025

25-ITP-SEP| Data groups | Shreef Ibrahim| shreefAhmedM/My-Coursework-Planner#50

Open

illicitonion closed this Jan 7, 2026

		@@ -1,3 +1,5 @@
		function contains() {}

		function contains(obj, prop) {

Uh oh!

Conversation

shreefAhmedM commented Oct 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants