Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 1 | Sprint1-exercise by Abrsh100 · Pull Request #811 · CodeYourFuture/Module-Data-Groups

Abrsh100 · 2025-11-03T07:56:03Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have done all the tasks required for this sprint

Questions

No questions

…any bug in th file.

cjyuan

Code is good. I only have few suggestions.

cjyuan · 2025-11-15T01:06:08Z

Sprint-1/implement/dedupe.test.js

 // Then it should return a copy of the original array
+test("given an array with no duplicates", () => {
+  const input = [1, 2, 3, 4, 5];
+  const result = dedupe(input);
+  expect(result).toEqual([1, 2, 3, 4, 5]);
+});


The current test code cannot check if the returned array is a copy of the original array because toEqual() compares objects (including arrays) by value. To illustrate,

const A = [2, 3, 1]; const B = [...A]; // B is a copy of A // This set of code cannot distinguish if the compared objects are the same objects. expect(A).toEqual(A); // true expect(A).toEqual(B); // true

In order to check if the returned array is a copy of the original array, we would need additional checks.
Can you find out what code you need to add in order to ensure the returned value is not the original array?

Sprint-1/implement/sum.test.js

cjyuan · 2025-11-15T01:10:39Z

Sprint-1/implement/sum.js

 function sum(elements) {
-}
+    if (!Array.isArray(elements)) return null
+    const sumNum = elements.filter(n => typeof n === 'number' && !isNaN(n))


If you were required to filter out also Infinity and -Infinity, how would you express the filtering condition?

cjyuan

Can you also respond to this question ?

cjyuan · 2025-11-19T15:19:38Z

Sprint-1/implement/dedupe.js

 function dedupe(groupNumber) {
-    return [...new Set(groupNumber)];
+  const seen = new Set()
+  const deduped = []

+  for (const item of groupNumber) {
+    if (!seen.has(item)) {
+      seen.add(item)
+      deduped.push(item)
+    }
+  }
+
+  return deduped
 }


Why replaced the previous single-line statement with 10 lines code?

cjyuan · 2025-11-19T15:20:11Z

Sprint-1/implement/sum.js

-    if (!Array.isArray(elements)) return null
-    const sumNum = elements.filter(n => typeof n === 'number' && !isNaN(n))
-    return sumNum.reduce((accumulator, currentValue) => accumulator + currentValue, 0);
-};
-
+  return elements.reduce((accumulator, currentValue) => {
+    if (typeof currentValue === "number") {
+      return accumulator + currentValue;
+    }
+    return accumulator;
+  }, 0);
+}   


Why rewrote the code?

…y the code.

cjyuan · 2025-11-20T07:27:59Z

I wasn't asking you to change code.

Can you respond to my questions?

Abrsh100 · 2025-11-20T07:35:57Z

I am sorrry which question did I didn't respond

cjyuan · 2025-11-20T10:00:39Z

All of these (see pic). You made some changes accordingly but that was not the same as responding to the comments. When I asked, "Why rewrote this code?", I literally wanted to know the rationale behind your decision.

Abrsh100 · 2025-11-26T06:56:19Z

yes I got it now sorry for not responding properly.
at dedube js. I change the code becouse i want the code in line 32 (dedube.test.js) is not a copy , which i was wrong so i serach and find out that to make sure that both of the input and result are copy of each ather i have to use toStrictEqual.

in sum.js I rewrote the code because I thought that if there is a value wich is nan the sum,test.js will throw an error but when i notice that the tests are writen to ignor the NAN and add the Number there fore i writern to my first code and this code ignor the NAN. by the .filter() in which only number are included in the summation

cjyuan · 2025-11-26T15:33:58Z

Sprint-1/implement/dedupe.test.js

 // Then it should return a copy of the original array
+test("given an array with no duplicates", () => {
+  const input = [1, 2, 3, 4, 5];
+  const result = dedupe(input);
+  expect(result).toStrictEqual([1, 2, 3, 4, 5]);
+});


"A is a copy of B" means A and B refer to two different arrays.

The check you have does not check if result and input are two different arrays; it only checks if
result and [1,2,3,4,5] have the same type and elements.

Suggestion: look up "How to check if two arrays are different arrays with the same content in Jest?"

cjyuan · 2025-11-26T15:43:45Z

Sprint-1/implement/sum.js

+    if (typeof currentValue === "number" && Number.isFinite(currentValue)) {
+      return accumulator + currentValue;
+    }


FYI, the condition can further simplified.

cjyuan · 2025-12-02T22:07:01Z

Sprint-1/implement/dedupe.test.js

  const input = [1, 2, 3, 4, 5];
  const result = dedupe(input);
-  expect(result).toStrictEqual([1, 2, 3, 4, 5]);
+  expect(result).not.toBe([1, 2, 3, 4, 5]);


The syntax [1, 2, 3, 4, 5] always creates a new array.

On line 32, the statement is not checking if result and the array passed to dedupe() are different arrays.

Abrsh100 added 2 commits November 2, 2025 01:02

fix median.js

0c35c96

working in file.js to pass the file.test.js. I have chnged and fixed …

d5e7b34

…any bug in th file.

Abrsh100 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 3, 2025

cjyuan reviewed Nov 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

changing base on the comment provided

d7711a8

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 19, 2025

cjyuan reviewed Nov 19, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 19, 2025

it was a valuable comment and i communicate with the comment to modif…

954737e

…y the code.

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 19, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 20, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

clarification on the comment

7dd2776

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 26, 2025

cjyuan reviewed Nov 26, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 26, 2025

cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Nov 26, 2025

modification and some change in test

22de8fa

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025

cjyuan reviewed Dec 2, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 2, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

Abrsh100 commented Nov 3, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

Abrsh100 commented Nov 20, 2025

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

Abrsh100 commented Nov 26, 2025

Uh oh!

cjyuan Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants