Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Sprint2-exercise by Abrsh100 · Pull Request #820 · CodeYourFuture/Module-Data-Groups

Abrsh100 · 2025-11-07T12:23:24Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I fix the errors incounterd in the function as well as in the test and creat new function to pass the tests

Questions

no questions

…ion to pass the test

cjyuan

Code is very solid.
Indentation is a bit off in some of the files. Can you improve the indentation on these files?

cjyuan · 2025-11-15T01:17:43Z

Sprint-2/debug/author.js

  age: 40,
  alive: true,
 };
+console.log(author)


This works (for displaying the properties) to certain extent.

However, I think the objective of this exercise is to practice how to iterate through all the property values of an object. Can you figure out how to use a loop to accomplish that?

cjyuan · 2025-11-15T01:19:13Z

Sprint-2/implement/contains.js

+        return false;
+    }   
+
+    return properityValue in object;


Suggestion
Consider the following two approaches for determining if an object contains a property:

let obj = {}, propertyName = "toString"; console.log( propertyName in obj ); // true console.log( Object.hasOwn(obj, propertyName) ); // false

Which of these approaches suits your needs better?
For more info, you can look up JS "in" operator vs Object.hasOwn.

cjyuan · 2025-11-15T01:24:25Z

Sprint-2/implement/querystring.js

+    const index = pair.indexOf("=");
+    if (index === -1) {
+      queryParams[pair] = undefined;
+    } else {
+      const key = pair.slice(0, index);
+      const value = pair.slice(index + 1);
+      queryParams[key] = value;
+    } 


Please note that in real querystring, both key and value are percent-encoded or URL encoded in the URL. For example, the string "5%" will be encoded as "5%25". So to get the actual value of "5%25" (whether it is a key or value in the querystring), you should call a function to decode it.
May I suggest looking up any of these terms, and "How to decode URL encoded string in JS"?

cjyuan · 2025-11-15T01:26:09Z

Sprint-2/implement/tally.js

+function tally(input) {
+    if (!Array.isArray(input)) {
+        throw new Error("Input must be an array");
+    }
+
+   const counts = {};
+    for (let item of input) {
+        counts[item] = (counts[item] || 0) + 1;
+    }
+
+    return counts;
+}


Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

cjyuan · 2025-11-20T07:33:22Z

When you make changes based on review comments, please respond directly to each comment. Even a short acknowledgement is helpful. This makes the review process clearer, shows your reasoning, and ensures that nothing gets overlooked. Code review is a conversation, not just an edit pass.

cjyuan · 2025-11-20T07:38:44Z

Sprint-2/implement/querystring.js

+
+    for (const pair of keyValuePairs) {
+    const index = pair.indexOf("=");
+    if (index === -1) {
+      queryParams[decodeURIComponent(pair)] = undefined
+    } else {
+        const key = pair.slice(0, index);
+        const value = pair.slice (index + 1);
+        queryParams[key] = value;
+    }
+    return queryParams;

-  return queryParams;
+    }
 }


No all keys and values are properly URL-decoded.

The indentation is a bit off.

cjyuan · 2025-11-27T21:10:16Z

Sprint-2/implement/querystring.js

+    const queryParams = {};
+    if (!queryString ) return queryParams;
+
+     const keyValuePairs = queryString.split("&");

+     for (const pair of keyValuePairs) {
+     const index = pair.indexOf("=");
+     if (index === -1) {
+      queryParams[decodeURIComponent(pair)] = undefined
+     } else {
+        const key = decodeURIComponent (pair.slice(0, index));
+        const value = decodeURIComponent (pair.slice (index + 1));
+        queryParams[key] = value;
+     }
+
  return queryParams;
+
+  }
 }


Code is still not properly indented.

Why not use the VSCode built-in "Format document" feature (after installing the "prettier" VSCode extension) to auto format the code?

fixing the errors encountered in the code.,and creatining a new funct…

f8f0510

…ion to pass the test

Abrsh100 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 7, 2025

cjyuan reviewed Nov 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

change the code based on the comment

18b106c

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 19, 2025

cjyuan reviewed Nov 20, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025

decoding and indentation adjastement

bc33d58

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 26, 2025

cjyuan reviewed Nov 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 27, 2025

changing the format of the code

c1a83b4

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 2, 2025

illicitonion closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Sprint2-exercise#820

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Sprint2-exercise#820
Abrsh100 wants to merge 4 commits intoCodeYourFuture:mainfrom
Abrsh100:Sprint-2-excercise

Abrsh100 commented Nov 7, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Nov 15, 2025

Uh oh!

Abrsh100 Nov 19, 2025

Uh oh!

cjyuan Nov 15, 2025

Uh oh!

cjyuan Nov 15, 2025

Uh oh!

cjyuan Nov 15, 2025

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

cjyuan Nov 20, 2025

Uh oh!

cjyuan Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Abrsh100 commented Nov 7, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Abrsh100 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 20, 2025

Uh oh!

cjyuan Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants