London | 25-ITP-September | Ammad Ur Rehman | Sprint 3 | [TECH ED] Build alarm clock app#830
Closed
anosidium wants to merge 6 commits intoCodeYourFuture:mainfrom
Closed
London | 25-ITP-September | Ammad Ur Rehman | Sprint 3 | [TECH ED] Build alarm clock app#830anosidium wants to merge 6 commits intoCodeYourFuture:mainfrom
anosidium wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your alarm clock app works. Basically the core functionality the alarm clock should have works, and I have to commend you for attempting the extra tasks. One thing i noticed is when I click the stop alarm button, the screen keeps on blinking. But still a good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed all the tasks.
Questions
I don't understand why the requirements are structured the way they are.
pauseAlarm(), notstopAlarm(), and all it does is pause the audio track, it doesn’t actually stop the alarm. Why?In the Extra Tasks section, it says:
This is confusing, because “pause” normally means to temporarily suspend the timer, not to stop it completely. Yet, the instruction says “countdown stops and then restart it later”, which sounds more like stopping and restarting from the beginning rather than pausing and resuming.
I think it would make more sense like this: