Glasgow | 25-ITP-Sep | Mohammed Abdoon | Sprint 3| Alarm Clock #848

M-Abdoon · 2025-11-15T14:10:49Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Alarm clock app exercise done.

Questions

No questions so far, thank you.

github-actions · 2025-11-15T14:11:08Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-15T14:11:11Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

AbogeJr

Overall nice work @M-Abdoon. I've highlighted a few improvements you could make in the comments 👍

AbogeJr · 2025-11-22T09:27:00Z

Sprint-3/alarmclock/alarmclock.js

+  }, 1000);
+}
+
+function toMMSS (seconds) {


I think this function could have a more descriptive name? Maybe something that easily describes what the function does.

True. I changed the name to 'formatTimeMMSS()' so it shows what it actually does.

AbogeJr · 2025-11-22T09:28:36Z

Sprint-3/alarmclock/alarmclock.js

+    timeRemainingHTML.innerHTML = `Time Remaining: ${toMMSS(secondsLeft)}`;
+    pageTitle.innerHTML = `Time Remaining: ${toMMSS(secondsLeft)}`;
+
+    document.getElementById("pause").addEventListener("click", () => {


I'm not sure this is the best place to initialize an event listener. Please check it out to see why it would be problematic.

I would be problematic because it keeps adding a new listener every 100 ms. I moved the event out of setInterval().

AbogeJr · 2025-11-22T09:34:16Z

Sprint-3/alarmclock/alarmclock.js

+    let secondsLeft = Math.max(0, Math.ceil(timeDifference / 1000));
+
+    timeRemainingHTML.innerHTML = `Time Remaining: ${toMMSS(secondsLeft)}`;
+    pageTitle.innerHTML = `Time Remaining: ${toMMSS(secondsLeft)}`;


I think there is a better way to change the title of a html document.

Yes, I now used this way:
document.title =
instead of:
pageTitle.innerHTML =

AbogeJr · 2025-11-22T09:35:24Z

Sprint-3/alarmclock/alarmclock.js

-function setAlarm() {}
+function setAlarm() {
+  const timer = Number(document.querySelector("#alarmSet").value);
+  const timeRemainingHTML = document.querySelector("#timeRemaining");


Maybe we can have a better name for the variable here since we are referencing a single element?

I changed it to ' timeRemainingEl ' which means ' time remaining element '. I think that's a better way to name it.

AbogeJr · 2025-11-22T09:38:55Z

Sprint-3/alarmclock/alarmclock.js

+  const pageTitle = document.querySelector("title");

+  let targetTime = new Date().getTime() + timer * 1000;
+  console.log(targetTime);


This is fine during development but typically we clean them up before submission of work.

exactly! I removed it.

AbogeJr · 2025-11-22T09:46:31Z

Sprint-3/alarmclock/alarmclock.js

+  const doAlarm = setInterval( () => {
+    let timeThisSecond = new Date().getTime();
+    let timeDifference = targetTime - timeThisSecond;
+    let secondsLeft = Math.max(0, Math.ceil(timeDifference / 1000));


Good job using the Math functions here. 👌
Although, a minor improvement you should look into is when to use let to initialize variables.

Thank you ^^.
I replaced 'let' with 'const' since we won't need to change their values.

M-Abdoon · 2025-11-22T12:58:18Z

Overall nice work @M-Abdoon. I've highlighted a few improvements you could make in the comments 👍

Thank you so much for your review.
I made the required changes.

AbogeJr

Almost there 👌

AbogeJr · 2025-11-22T13:15:45Z

Sprint-3/alarmclock/alarmclock.js

+  document.getElementById("pause").addEventListener("click", () => {
+      pauseAlarm();
+      clearInterval(doAlarm);
+    });
+


Not quite. We're not supposed to edit the code in this section. Please check again.

Done. I changed its place.

AbogeJr · 2025-11-22T13:18:57Z

Sprint-3/alarmclock/alarmclock.js

+    const secondsLeft = Math.max(0, Math.ceil(timeDifference / 1000));
+
+    timeRemainingEl.innerHTML = `Time Remaining: ${formatTimeMMSS(secondsLeft)}`;
+    document.title = `Time Remaining: ${formatTimeMMSS(secondsLeft)}`;


Almost there but please check the first instruction about the "title" on the alarmclock readme.md

ah yes. I should have changed the page title so I put a default one and then it changes when the user clicks on the button.
I have set the title.

Okay I see the instruction is a little ambiguous, could be worded better but generally you won't want to update the page title, at least not in this way (every second).

ref:

First off, once you've branched off main, then update the title element in index.html to "Alarm clock app" You will need to write your implementation in alarmclock.js.

Should it maybe be like " Counting down ... " once the user clicks on the button? or maybe it should not change at all?

Yes. The title (on the browser tab) should remain as it is. The title (h1 inside the page should update)

Ok. I just updated the code, now the page title on the browser tab does not change anymore.

M-Abdoon · 2025-11-22T14:28:37Z

Thank you so much.
changes have been made.

AbogeJr

Looks good. One last thing, please check the <title> in the alarmclock.html

M-Abdoon · 2025-11-22T16:28:02Z

I changed the title. Thank you.

alarm clock exercise done

66654b6

M-Abdoon added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 15, 2025

M-Abdoon mentioned this pull request Nov 16, 2025

25-ITP-SEP | Data Groups | Mohammed Abdoon M-Abdoon/My-Coursework-Planner#89

Open

AbogeJr added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

AbogeJr reviewed Nov 22, 2025

View reviewed changes

AbogeJr added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 22, 2025

alarmclock.js updated

85550ac

M-Abdoon added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025

AbogeJr added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

AbogeJr reviewed Nov 22, 2025

View reviewed changes

AbogeJr added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 22, 2025

M-Abdoon added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025

alarmclock.js updated

f3a6968

AbogeJr added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

AbogeJr reviewed Nov 22, 2025

View reviewed changes

AbogeJr added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 22, 2025

Change title to 'Alarm clock app'

c5f92eb

M-Abdoon added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025

AbogeJr added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

Uh oh!

Glasgow | 25-ITP-Sep | Mohammed Abdoon | Sprint 3| Alarm Clock #848

Are you sure you want to change the base?

Glasgow | 25-ITP-Sep | Mohammed Abdoon | Sprint 3| Alarm Clock #848

Uh oh!

Conversation

M-Abdoon commented Nov 15, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

AbogeJr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M-Abdoon Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M-Abdoon commented Nov 22, 2025

Uh oh!

AbogeJr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AbogeJr Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AbogeJr Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M-Abdoon commented Nov 22, 2025

Uh oh!

AbogeJr left a comment

Choose a reason for hiding this comment

Uh oh!

M-Abdoon commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

M-Abdoon Nov 22, 2025 •

edited

Loading

AbogeJr Nov 22, 2025 •

edited

Loading

AbogeJr Nov 22, 2025 •

edited

Loading