London | 25-ITP-Sep| Sophia Mohamed | Sprint 1 | Sprint 1 Coursework

[saff-coder]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have completed all mandatory tasks.

Questions

[cjyuan]

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/sprint-1-feedback/Sprint-1/feedback.md

Doing so can help reviewers speed up the review process. Thanks.

[saff-coder]

median.js
My implementation now avoids mutating the original array by cloning once before sorting. I use filter to create a new array of numeric values and then use the spread operator ([...numbers]) to create a sorted copy. I don’t create any extra clones beyond those two necessary ones.

dedupe.test.js
In Jest, toEqual checks that two arrays have the same contents, but doesn’t guarantee they are different objects. To check they are different arrays, we should use toBe for identity

Sprint-1/implement/sum.test.js
For the sum tests, I learned that decimal numbers in JavaScript use floating-point arithmetic, which can introduce tiny rounding errors.
That means a direct comparison like:
expect(sum([1.2, 0.6, 0.005])).toEqual(1.805);
might fail even if the function is logically correct.
To handle this, I used Jest’s toBeCloseTo matcher, which is designed for floating-point comparisons:
expect(sum([1.2, 0.6, 0.005])).toBeCloseTo(1.805);

[cjyuan]

numbers is not the original array, and it is not needed afterward.

[saff-coder]

Thanks for the feedback!
I removed the unnecessary clone ([...numbers])

[cjyuan]

Nicely done.

[cjyuan]

This test has not been implemented. (You would have to replace the least surprising value by an exact value which you expect)

[saff-coder]

Thanks so much for spotting those issues!
I went back and fixed the incorrect variable name inside max.js, removed some leftover code from the median exercise, and updated the test that was still calling calculateMedian.
Everything now works as expected, and all tests pass.
Really helpful feedback — thank you!

[cjyuan]

The function in this file has has not yet been refactored to meet the spec on line 1.

[saff-coder]

Thanks for the feedback!
You're right — I had not refactored the includes function yet.
I've now updated the implementation so that it meets the requirement on line 1 and added tests to confirm it works as intended.

[cjyuan]

Changes look good. Well done!

[cjyuan]

You can also consider introducing a variable with a more meaningful name as

const sorted = numbers.sort((a, b) => a - b);