Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|coursework#988
Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|coursework#988mjm-git185 wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
mjm-git185
added
the
Needs Review
WeiTsungCheng
added
Review in progress
There was a problem hiding this comment.
This does not meet the purpose of the question.
The goal of the program is to output the values of all properties in the object.
There was a problem hiding this comment.
i have changed this so it only logs the values now
There was a problem hiding this comment.
What problems might arise if the quantity of ingredient changes later (e.g., to 100)?
Sprint-2/implement/lookup.js
Outdated
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryAndCurrency) { | ||
| const money = new Map(countryAndCurrency); |
There was a problem hiding this comment.
some edge cases need to be considered
There was a problem hiding this comment.
i have made changes to the test for more edge cases, now i need to fix the code to pass the tests
There was a problem hiding this comment.
function tally(arr) has use console.log
why need console.log(tally(["a", "a", "b", "c"])); ???
There was a problem hiding this comment.
why test expect(tally(["a", "b", "a"])).toEqual({ a: 2, b: 1 }); twice?
| }); | ||
|
|
||
| // Given an invalid input like a string | ||
| // When passed to tally |
WeiTsungCheng
added
Reviewed
mjm-git185
added
Needs Review
WeiTsungCheng
added
Complete
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 similar comments
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Great You have fixed |
2 participants
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework