This repository was archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Orlando_Morales | JS-2-Module-alarmclock | Week3#191
Open
OrlandoMoralesKuan wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
NW6 | Orlando_Morales | JS-2-Module-alarmclock | Week3#191OrlandoMoralesKuan wants to merge 2 commits intoCodeYourFuture:mainfrom
OrlandoMoralesKuan wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OrlandoMoralesKuan
changed the title
SpectacularLandscape
left a comment
SpectacularLandscape
left a comment
There was a problem hiding this comment.
This is a great alarm clock, Orlando! All of the tests are green and it feels great to use.
You have hit most of the acceptance criteria, just watch out for this one:
Given the alarm is set with a time of 00:00
When the timer reaches 00:00
Then the alarm sound should play continuously
But otherwise well done on building this app!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.