Skip to content

London | 26-ITP-Feb | Shuheda Begum | Sprint 1 | Coursework#1066

Closed
codebyshay wants to merge 0 commit intoCodeYourFuture:mainfrom
codebyshay:Sprint-1
Closed

London | 26-ITP-Feb | Shuheda Begum | Sprint 1 | Coursework#1066
codebyshay wants to merge 0 commit intoCodeYourFuture:mainfrom
codebyshay:Sprint-1

Conversation

@codebyshay
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all task required in Sprint 1

Questions

No questions.

@codebyshay codebyshay added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 25, 2026
Comment on lines +1 to +8
const cardNumber = 4533787178994213;
const last4Digits = cardNumber.slice(-4);
// Currently trying to print the string "I was born in Bolton" but it isn't working...
// what's the error ?

// The last4Digits variable should store the last 4 digits of cardNumber
// However, the code isn't working
// Before running the code, make and explain a prediction about why the code won't work
// Then run the code and see what error it gives.
// Consider: Why does it give this error? Is this what I predicted? If not, what's different?
// Then try updating the expression last4Digits is assigned to, in order to get the correct value
const cityOfBirth = "Bolton";
console.log(`I was born in ${cityOfBirth}`);

// The error happens because cityOfBirth is used before it is defined. JavaScript
// runs code from top to bottom, so the variable must be declared first. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original content in this file was replaced with the content meant for 2.js.

Can you restore the original content and fix the error ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026
@codebyshay codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 5, 2026

I don't see any new commits on this PR branch.
Did you make your changes on the correct branch?
Have you pushed your changes to GitHub?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026
@codebyshay
Copy link
Author

Sorry @cjyuan I was having issues pushing the commit through. All sorted now. You should be able to see the commits now. Thank you.

@codebyshay codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@codebyshay codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026
@codebyshay codebyshay closed this Mar 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 5, 2026

Something went wrong. All changes are now gone when you make a force-pushed. I hope you have a backup.

In case you need to find the content before the forced pushed, you can find them here:
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/compare/fb7752829535ede295b219e95b708550250a1756..124ae4518ceceef7e4c918025d74e9752f1ec180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants