Skip to content

WestMidlands | Danial Bashirzadeh | Module-Structuring-and-Testing-Data | Week 3 exercises ( Sprint 3 ) #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bashirzadehdanial wants to merge 50 commits into from
Closed

WestMidlands | Danial Bashirzadeh | Module-Structuring-and-Testing-Data | Week 3 exercises ( Sprint 3 ) #112

bashirzadehdanial wants to merge 50 commits into from

Conversation

@bashirzadehdanial
Copy link

@bashirzadehdanial bashirzadehdanial commented Nov 10, 2024 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@bashirzadehdanial
Explain behavior of multiply function and console output
0112344
@bashirzadehdanial
Fix sum function to correctly return the sum of two numbers
bfad6a6
@bashirzadehdanial
Refactor getLastDigit to accept a parameter and return the last digit…
c950527 
… of the given number
@bashirzadehdanial
Fix redeclaration error in capitalise function by removing 'let' keyword
d633f6e
@bashirzadehdanial
Fix redeclaration error in convertToPercentage function and correct c…
a9c5318 
…onsole log usage
@bashirzadehdanial
Fix SyntaxError by using a valid parameter name in square function
0f5cde6
@bashirzadehdanial
Predict before run the code and then fix the error by modification of…
62e1690 
… the code
@bashirzadehdanial
Fix multiply function by adding return expression to the function
80067d8
@bashirzadehdanial
Remove semicolon
7452f54
@bashirzadehdanial
Fix the function bugs & test for Midnight
20df389
@bashirzadehdanial
Fix the function bugs & test for Midnight
e9cdf3c
@bashirzadehdanial
Fix the function bugs & test for Noon
c953d97
@bashirzadehdanial
Fix the function bugs & test for Afternoon
11a9489
@bashirzadehdanial
Fix the function bugs & test for Morning
34835f1
@bashirzadehdanial
Implement BMI calculation function
cf9ba6d
@bashirzadehdanial
Implement toUpperCaseWords function which Convert the string to upper…
d944ed1 
…case & Replace spaces with underscores
@bashirzadehdanial
implement toPounds function for currency conversion to be reusable op…
8dcc390 
…posite of the previous method in sprint1
@bashirzadehdanial
Implement VAT calculation function
34d4275
@bashirzadehdanial
Answer questions regarding formatTimeDisplay function
a9455a9
@bashirzadehdanial
Implement getAngleType function to classify angle types
f9e3d6b
@bashirzadehdanial
Implement getCardValue function to determine Blackjack card values
c59dafc
@bashirzadehdanial
Implement multiple utilities
c849fef
@bashirzadehdanial
Implement isValidTriangle function to validate triangle side lengths
2469246
@bashirzadehdanial
Implement rotateCharacter function to rotate letters with shift
353d1c6
@bashirzadehdanial
Implement countChar function to count occurrences of a character in a…
ca811ab 
… string
@bashirzadehdanial
Implement getOrdinalNumber function with ordinal suffix rules and Jes…
9c772ab 
…t tests
@bashirzadehdanial
Add isPrime function with basic tests
5d3ac35
@bashirzadehdanial
Add tests for countChar function
ff60bb0
@bashirzadehdanial
Implement password validation function with tests
9a88d61
@bashirzadehdanial
Implement repeat function with tests
6217cf3
@bashirzadehdanial bashirzadehdanial added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2024
@bashirzadehdanial
Add tests for getAngleType function
a5ed524
@bashirzadehdanial
Add test for Function should throw an error when the denominator is zero
90f6f61
@bashirzadehdanial
Add test for Function should return false if denominator is equal to …
b323d2a 
…numerator
@bashirzadehdanial
Add test for Function should return true if numerator is smaller than…
af213ec 
… denumerator
@bashirzadehdanial
Function should return true if numerator is greater than denumerator
b1edeaa
@bashirzadehdanial
Add test for sum of two sides of the trianglt is greater than the thi…
e6d2ac4 
…rd side, which should return true
@bashirzadehdanial
Add test for sum of two sides of the trianglt is smaller than the thi…
350c90d 
…rd side, which should return false
@bashirzadehdanial
Add test for isValidTriangle function, which should return false for …
733123e 
…negative number as parameters
@bashirzadehdanial
Add test for rotateCharacter function as it should rotate the lowerca…
7dde649 
…se letter by shift positions within the lowercase alphabet
@bashirzadehdanial
Add test for rotateCharacter function as it should rotate the upperca…
b5c0968 
…se letter by shift positions within the lowercase alphabet
@bashirzadehdanial
Add test for rotateCharacter function as it should return the charact…
ee6bfdc 
…er unchanged as the given character is not a letter
@bashirzadehdanial
Add test for rotateCharacter function as it should rotate the charact…
964af59 
…er by shift positions within the alphabet while handling the wraparound
@bashirzadehdanial
Add tests for getCardValue function as it should return the numeric v…
b222b1d 
…alue corresponding to the rank between 2 and 10
@bashirzadehdanial
Add tests for getCardValue function as it should return the value 11,…
c79c8a9 
… which is a common rule in blackjack
@bashirzadehdanial
Add test for its functionality as it should return Invalid card rank …
5618d57 
…for any invalid rank length
@SallyMcGrath
Copy link
Member

SallyMcGrath commented Nov 18, 2024

Hi @bashirzadehdanial looks like you have two sprints of work in one PR here. Please clean up your PR. LOTS of people encounter this problem, so come to class or Slack to get help fixing it. (And always open your new branch from main in the future! 😅 )

@SallyMcGrath SallyMcGrath added 👀 Review Git Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bashirzadehdanial @SallyMcGrath