WM4 | FATIMA_SAFANA | Module-Structuring-and-Testing-Data | WEEK5#220
Closed
Fatimasfn wants to merge 12 commits intoCodeYourFuture:mainfrom
Closed
WM4 | FATIMA_SAFANA | Module-Structuring-and-Testing-Data | WEEK5#220Fatimasfn wants to merge 12 commits intoCodeYourFuture:mainfrom
Fatimasfn wants to merge 12 commits intoCodeYourFuture:mainfrom
Conversation
Fatimasfn
added
the
Needs Review
Fatimasfn
changed the title
loveth900
removed
the
Needs Review
Contributor
|
@Fatimasfn Does this Sprint 2 PR need review? @loveth900 May I know why you removed the "Needs Review" label from this PR? |
Fatimasfn
added
the
Needs Review
Author
|
@cjyuan yes please, I will appreciate a review |
cjyuan
reviewed
Dec 10, 2024
| const decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
| //const decimalNumber = 0.5; | ||
| return percentage = `${decimalNumber * 100}%`; |
Contributor
There was a problem hiding this comment.
What is percentage? Do you need it?
| const vat = 0.2; | ||
| const priceWithoutPoundSign = Number(price.substring(1)); | ||
| return `£${(vat * priceWithoutPoundSign) + priceWithoutPoundSign}`; | ||
| } |
Contributor
There was a problem hiding this comment.
The spec is a bit vague, but I think it will probably make more sense for this function to deal with a number directly and return a number.
But what's matter is that you know how to implement a function. So no change is necessary.
cjyuan
added
Reviewed
Author
|
@cjyuan Thank you for the review, I really appreciate it . |
Fatimasfn
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.