Skip to content

My work#241

Closed
Aomahmed wants to merge 6 commits intoCodeYourFuture:mainfrom
Aomahmed:my_work
Closed

My work#241
Aomahmed wants to merge 6 commits intoCodeYourFuture:mainfrom
Aomahmed:my_work

Conversation

@Aomahmed
Copy link

@Aomahmed Aomahmed commented Jan 19, 2025

NW | Ahmed Mahmoud | Module-Structuring-and-Testing-Data | WEEK1

Self checklist

  • [*] I have committed my files one by one, on purpose, and for a reason
  • [*] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [*] I have tested my changes
  • [*] My changes follow the style guide
  • [*] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Could someone kindly review my work and provide feedback?

@Grajales-K
Copy link

Grajales-K commented Jan 19, 2025

Self checklist

  • [*] I have committed my files one by one, on purpose, and for a reason
  • [*] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [*] I have tested my changes
  • [*] My changes follow the style guide
  • [*] My changes meet the requirements of this task

Hi @Aomahmed, you market this as done, but did you read each one and follow the style? For example, your title does not meet the requirements. Could you please update your title and double-check the list to ensure your job is correct, also your branch does not have an appropriate name to receive good feedback later on. thank you.

@Aomahmed Aomahmed closed this by deleting the head repository Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants