Skip to content

Cpt | Jan2025 | Evelyn Nomsa Mwanunura | Module-Structuring-and-Testing-Data | Sprint 1 #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EvelynMwanunura wants to merge 18 commits into from
Closed

Cpt | Jan2025 | Evelyn Nomsa Mwanunura | Module-Structuring-and-Testing-Data | Sprint 1 #243

EvelynMwanunura wants to merge 18 commits into from

Conversation

@EvelynMwanunura
Copy link

@EvelynMwanunura EvelynMwanunura commented Jan 27, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

In this PR i learnt how to read documentation, spot errors in a code and explain how some methods and operators work in JavaScript.

Questions

Ask any questions you have for your reviewer.

@EvelynMwanunura EvelynMwanunura changed the title Cpt | Jan2025 | Evelyn Nomsa Mwanunura | Sprint-2 - Module-Structuring-and-Testing-Data | Sprint 1 Cpt | Jan2025 | Evelyn Nomsa Mwanunura | Module-Structuring-and-Testing-Data | Sprint 1 Jan 27, 2025
@halilibrahimcelik halilibrahimcelik self-requested a review January 27, 2025 11:41
@halilibrahimcelik
Copy link

halilibrahimcelik commented Jan 27, 2025

Once you created your PR pls do not forget to add reviews needed label. This is essential as reviewers we can filter these labels to check whether or not you require a review

@halilibrahimcelik halilibrahimcelik added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 27, 2025
halilibrahimcelik
halilibrahimcelik approved these changes Jan 28, 2025
View reviewed changes
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, you provided detailed and informative answers for each tasks, keep up the good work.

@halilibrahimcelik halilibrahimcelik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 28, 2025
@EvelynMwanunura
Copy link
Author

EvelynMwanunura commented Jan 28, 2025

a

Thank you.

@EvelynMwanunura EvelynMwanunura mentioned this pull request Jan 31, 2025
Open
@EvelynMwanunura EvelynMwanunura added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@halilibrahimcelik halilibrahimcelik halilibrahimcelik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EvelynMwanunura @halilibrahimcelik @illicitonion