ITP-JAN-25 | London | Saba Farjamfard | Module-Structuring-and-Testing-Data |Sprint 2| Week 2 #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabafarjamfard
added
the
Needs Review
halilibrahimcelik
added
Review in progress
halilibrahimcelik
suggested changes
Feb 5, 2025
| } No newline at end of file | ||
| const bmi = weight / (height * height); | ||
| // return the BMI of someone based off their weight and height | ||
| return parseFloat(bmi.toFixed(1)); |
There was a problem hiding this comment.
Well done, you can even enhance this fn by also returning result about people's bmi . Consider this as a challenge and if you have time go for it.
| let formattedHours = hours; | ||
|
|
||
| if (hours === 0) { | ||
| formattedHours = 12; // Midnight case |
There was a problem hiding this comment.
Well done, you checked all possible scenarios and wrote clean code.
sabafarjamfard
added
Needs Review
halilibrahimcelik
approved these changes
Feb 5, 2025
halilibrahimcelik
added
Reviewed
|
Thank you, you can close this PR |
sabafarjamfard
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.