ITP_J25_LDN| EYUEL_ABRAHAM | Module-Structuring-and-Testing-Data Coursework/sprint 2 | WEEK-2 #258

eyuell21 · 2025-02-06T15:12:35Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.
Completed the exercises given for sprint two.

Questions

Ask any questions you have for your reviewer.

…end, sprint 2.

BenSymons · 2025-02-08T15:37:14Z

Sprint-2/1-key-errors/1.js


 // =============> write your explanation here
-
+// trying to redeclare the variable called decimalNumber twice in the function.


also- the code was not invoking the convertToPercentage function which you corrected

BenSymons · 2025-02-08T15:45:23Z

Sprint-2/2-mandatory-debug/1.js

+// console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);

-// =============> write your explanation here
+// =============> write your explanation here: The sum of 10 and 32 is undefined because a+b is written under the return statement.


it is actually because that is what the function returns. return; will always return undefined. It is the same as writing return undefined

Noted. Thanks.

BenSymons · 2025-02-08T15:57:14Z

Sprint-2/2-mandatory-debug/2.js

+// console.log(`The last digit of 806 is ${getLastDigit(806)}`);

-function getLastDigit() {
+// Now run the code and compare the output to your prediction


You've corrected the mistake but your explanation isn't quite right. The problem was the number wasn't passed into the function as a parameter

BenSymons · 2025-02-08T16:03:04Z

Sprint-2/3-mandatory-implement/2-cases.js

 // You will need to come up with an appropriate name for the function
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+


fun fact- this is sometimes called screaming snake case!

fernandamelov · 2025-02-08T16:22:56Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+    let pounds = paddedPenceNumberString.substring(0,paddedPenceNumberString.length - 2);
+    const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0");
+    return `£${pounds}.${pence}`
+}


Great job so far !

try and test this one here:

function changeToPounds(penceString){
return £${(parseInt(penceString) / 100).toFixed(2)};
}

This is a robuster method to convert to pounds, and easier to understand . You don't need to worry about where de letter p will appear in the string, when using parseInt , it removes all letters elements from the value and takes just the numbers.

And then , just divide it to 100 to transform pence in pounds .

Done. This method is very simple and amazing. Thankyou!

fernandamelov

Great job so far !

try and test this one here for 3-mandatory-implement/3-to-pounds.js:

function changeToPounds(penceString){
return £${(parseInt(penceString) / 100).toFixed(2)};
}

This is a robuster method to convert to pounds, and easier to understand . You don't need to worry about where de letter p will appear in the string, when using parseInt , it removes all letters elements from the value and takes just the numbers.

And then , just divide it to 100 to transform pence in pounds .

BenSymons · 2025-02-08T16:25:39Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

 // You should call this function a number of times to check it works for different inputs
+
+function changeToPounds(penceString){
+    let penceStringWithoutTrailingP = penceString.substring(0,penceString.length - 1);


string.slice() is a little easier for this

let penceStringWithoutTrailingP = penceString.slice(0, -1);

Okay. Thankyou!

BenSymons · 2025-02-08T16:49:26Z

Sprint-2/4-mandatory-interpret/time-format.js

 // a) When formatTimeDisplay is called how many times will pad be called?
 // =============> write your answer here
-
+// three times 


is there a way you can check this?

We can use a global variable, which is increased each time the function is called.(got it from stackoverflow).

var myFuncCalls = 0;

function pad(num) {
myFuncCalls++;
console.log( "I have been called " + myFuncCalls + " times" );
return num.toString().padStart(2, "0");

}

BenSymons · 2025-02-08T16:52:10Z

Sprint-2/4-mandatory-interpret/time-format.js

+// three times 
 // Call formatTimeDisplay with an input of 61, now answer the following:

 // b) What is the value assigned to num when pad is called for the first time?


this depends on the number passed in at the start. If it's big enough it will be more than 0

Noted, Thankyou for the review.

BenSymons · 2025-02-08T19:03:32Z

Sprint-3/1-key-implement/1-get-angle-type.js


 function getAngleType(angle) {
-   if (angle === 90) return "Right angle";
+  if (angle === 90) return "Right angle";


none of these if statements need to be else if or else because you are returning a value from the function. Whenever you return something from a function, the execution stops so none of the code below is executed.

Also, you know that an angle is < 90 because the code carried on past that if statment so you only need to do:

if(angle < 90) return "Acute angle"; if(angle < 180) return "Obtuse angle"; if(angle < 360) return "Reflex angle";

etc

Feel free to message me if this doesn't make sense

This commit and the one after this were not supposed to be on this Pull request as they are from sprint three they are here by accident. I'll have to redo them with other the sprint 3 question on a new branch and a new PR for sprint 3.

BenSymons · 2025-02-08T19:04:21Z

Sprint-3/1-key-implement/1-get-angle-type.js

+  else if (angle === 180) return "Straight angle"
+  else if (angle > 180 && angle < 360) return "Reflex angle"
+  else if(angle === 360)  return "Full angle"
+  else return "please insert a valid angle (0-356)"


angles up to 360 should be valid

BenSymons · 2025-02-08T19:10:57Z

Sprint-3/1-key-implement/2-is-proper-fraction.js


 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    if (Math.abs(numerator) < Math.abs(denominator) && numerator !=0 && denominator != 0) return true;


Careful. the Math.abs() method just takes any negative number and turns it into a positive which would break this function in certain scenarios.

For example: console.log(isProperFraction(-5, 3)); would incorrectly return false when it is a proper fraction.

Do you know how you could fix this bug? Feel free to message me if you need a hand

BenSymons

A few suggestions and some small mistakes here and there but for the most part, well done!

…tion from review on my work.

… first state.

halilibrahimcelik · 2025-02-17T20:10:23Z

Well done you can close this PR now

eyuell21 added 5 commits February 1, 2025 15:43

Completed key errors on sprint two.

92bf57c

completed mandatory debugs on sprint 2

8022abe

Completed mandatory-implement on sprint 2

a86339b

completed 4-mandatory-interpret on sprint 2

5382597

Fixed some bugs and added some lines to the given code on stretch-ext…

f44fb8b

…end, sprint 2.

eyuell21 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2025

completed 1 and 2

9f6e26d

BenSymons reviewed Feb 8, 2025

View reviewed changes

fernandamelov reviewed Feb 8, 2025

View reviewed changes

fernandamelov suggested changes Feb 8, 2025

View reviewed changes

BenSymons reviewed Feb 8, 2025

View reviewed changes

eyuell21 added 6 commits February 8, 2025 20:20

changed the code according to the comment.

b629997

Added a comment

678810e

Added a comment from a review on github

17705c1

changed my code according to a review from a mentor on my PR.

cd4ef49

added a method to count how many times pad is called to answer a ques…

082c74a

…tion from review on my work.

accidentally committed it with sprint two. I have returned it to it's…

4d7ff35

… first state.

eyuell21 assigned eyuell21 and halilibrahimcelik and unassigned eyuell21 Feb 15, 2025

eyuell21 requested a review from BenSymons February 15, 2025 23:14

eyuell21 assigned illicitonion and halilibrahimcelik and unassigned halilibrahimcelik Feb 17, 2025

illicitonion closed this Sep 1, 2025


		// =============> write your explanation here

		// trying to redeclare the variable called decimalNumber twice in the function.

Uh oh!

ITP_J25_LDN| EYUEL_ABRAHAM | Module-Structuring-and-Testing-Data Coursework/sprint 2 | WEEK-2 #258

ITP_J25_LDN| EYUEL_ABRAHAM | Module-Structuring-and-Testing-Data Coursework/sprint 2 | WEEK-2 #258

Uh oh!

Conversation

eyuell21 commented Feb 6, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandamelov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenSymons left a comment

Choose a reason for hiding this comment

Uh oh!

halilibrahimcelik commented Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants