Lon_ITP_Jan_25 | Franklin D Kamela | Module Structuring and Storing Data | Sprint_1 #261
Conversation
Fradoka
added
the
Needs Review
GergelyKI
left a comment
GergelyKI
left a comment
There was a problem hiding this comment.
It looks good, I left a few comment here and there.
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| let initials = ``; | ||
| let initials = `${firstName.charAt(0)+middleName.charAt(0)+lastName.charAt(0)} `; |
There was a problem hiding this comment.
Here, you concatenate strings values with the + operator. This result in a string already. There's no need to use the template literal: ${} .
Advanced tip:
Concatenating strings with the + operator is considered slow in general. This is what the template literals can help with. So if you do it like this, probably it could be faster:
${firstName.charAt(0)} ${middleName.charAt(0)} ${lastName.charAt(0)}
Sprint-1/1-key-exercises/4-random.js
Outdated
| // the math.random() generates a random number from 0 to 1 | ||
| // the Math.random() * (maximum - minimum + 1) scales the random number to a range of (maximum - minimum + 1) | ||
| // this helps to cover all possible values from minimum to maximum | ||
| // the Math.floor(...) rounds up the result to make sure we get an integer value |
There was a problem hiding this comment.
Is this rounding up for sure? Why would the name be floor?
hint: there's another function, Math.ceil(...)
Sprint-1/2-mandatory-errors/3.js
Outdated
| @@ -1,6 +1,11 @@ | |||
| const cardNumber = 4533787178994213; | |||
| const cardNumber = "4533787178994213"; | |||
There was a problem hiding this comment.
This works, however you have change the data type from number to string?
How could you keep it a number?
Tip: the last 4 digits mean the remainder if you divide by 10 000.
|
@GergelyKI i reviewed and addressed feedback. could you please review |
|
@halilibrahimcelik could you please review my code? |
halilibrahimcelik
added
Reviewed
Fradoka
added
the
Complete
4 participants
Learners, PR Template
Self checklist
Changelist
Completed tasks for Sprint 1 of module Structuring and storing data
Questions
Ask any questions you have for your reviewer.