ITP-LONDON-JAN | FOROGH AGHAEIYARIJANI | MODULE STRUCTURING -AND - TESTING -DATA | SPRNT 1 | WEEK1 | solution tasks #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forogh-Aghaeiyarijani
added
the
Needs Review
|
The thing is when you committing your changes, do not commit all changes under one commit. Please try to divide each related changes under related commit |
halilibrahimcelik
approved these changes
Feb 17, 2025
halilibrahimcelik
left a comment
halilibrahimcelik
left a comment
There was a problem hiding this comment.
Good job, only thing I would like to remind you that please divide your changes into specific commits next time. It will also allow reviewers to inspect your changes
| // Currently trying to print the string "I was born in Bolton" but it isn't working... | ||
| // what's the error ? | ||
|
|
||
| console.log(`I was born in ${cityOfBirth}`); |
There was a problem hiding this comment.
Can you please explain to me what is the error ?
There was a problem hiding this comment.
In the original code, console.log(...) is executed before cityOfBirth is initialized, causing a ReferenceError.
| // The code will work for most values, but there are some edge cases where it could produce incorrect or unexpected results: | ||
| // Negative values: The code does not handle negative values for movieLength, resulting in negative times (e.g., -1:-30:-10), which doesn’t make sense in this context. | ||
| // Values less than 60: If movieLength is less than 60 seconds, the hours and minutes will be 0, which works fine. For example, movieLength = 45 will give 0:0:45. | ||
| // Large values: The code can handle very large values, but there’s no limit or check on the maximum duration. |
halilibrahimcelik
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.