Skip to content

Conversation

@FaraiMuzah
Copy link

No description provided.

@FaraiMuzah FaraiMuzah added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2025
// Currently trying to print the string "I was born in Bolton" but it isn't working...
// what's the error ?

console.log(`I was born in ${cityOfBirth}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not the correct words.

What do you call it when you declare a variable for the first time?

@@ -0,0 +1,2 @@
const 12HourClockTime = "20:53";
const 24hourClockTime = "08:53"; No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all the code from your closed pr here. You have skipped some files

@Waldo-Strydom Waldo-Strydom added 👀 Review Requirements Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 11, 2025
@Waldo-Strydom
Copy link

You have the same files in week 6 and 7. Please fix it. We do not have time to mark the same stuff

@FaraiMuzah
Copy link
Author

@Waldo-Strydom I didn't answer sprint 1 questions in this branch. I only answered sprint 2 as the title indicates

// A redeclaration is done of decimalNumber which stores the the value 0.5 but will cause an error since we can't redeclare in javascript
// A variable percentage is declared which will stores the evaluation of a decimal number to a percentage
// return will end the function and give the percentage value
// console.log will result in an error because it is outside the function and also not defined
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Waldo-Strydom line 21 contains the changes i made yesterday. I am confused why it still doesn't show on your side the changes I make whenever you advise.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 18. If you correct it in line 21, why keep line 18 when it is incorrect?

@Waldo-Strydom Waldo-Strydom added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed 👀 Review Requirements labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants