Skip to content

ITP-LONDON-JAN 25|FOROGH AGHAEIYARIJANI|MODULE-STRUCTURING-AND-TESTING-DATA |SPRINT-2|WEEK-2| Solutions #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Forogh-Aghaeiyarijani wants to merge 3 commits into from
Closed

ITP-LONDON-JAN 25|FOROGH AGHAEIYARIJANI|MODULE-STRUCTURING-AND-TESTING-DATA |SPRINT-2|WEEK-2| Solutions #295

Forogh-Aghaeiyarijani wants to merge 3 commits into from

Conversation

@Forogh-Aghaeiyarijani
Copy link

@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani commented Feb 16, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2025
@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani changed the title LONDON-JAN 25-MODULE-STRUCTURING-AND-TESTING-DATA |FOROGH AGHAEIYARIJANI|SPRINT-2|WEEK-2| Solutions ITP-LONDON-JAN 25|FOROGH AGHAEIYARIJANI|MODULE-STRUCTURING-AND-TESTING-DATA |SPRINT-2|WEEK-2| Solutions Feb 16, 2025
DouglasVDM
DouglasVDM suggested changes Feb 16, 2025
View reviewed changes
Copy link

@DouglasVDM DouglasVDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comment on the respective files

Sprint-2/4-mandatory-interpret/time-format.js Outdated

// b) What is the value assigned to num when pad is called for the first time?
// =============> write your answer here
// =============> write your answer here:0
Copy link

@DouglasVDM DouglasVDM Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value assigned to num when pad is called for the first time is 0, because totalHours is 0 based on the time conversion calculations.

@DouglasVDM DouglasVDM added Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module and removed 📅 Sprint 2 Assigned during Sprint 2 of this module labels Feb 16, 2025
@Forogh-Aghaeiyarijani
Copy link
Author

Forogh-Aghaeiyarijani commented Feb 18, 2025

Thank you for reviewing my PR. I did it.

@OracPrime OracPrime removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 2, 2025
@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DouglasVDM DouglasVDM Awaiting requested review from DouglasVDM

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Forogh-Aghaeiyarijani @DouglasVDM @illicitonion @OracPrime