Skip to content

ITP-JAN-25 | LONDON | Bakytbek Sydykov | Module-Structuring-and-Testing-Data | sprint 2 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bahasyd wants to merge 19 commits into from
Closed

ITP-JAN-25 | LONDON | Bakytbek Sydykov | Module-Structuring-and-Testing-Data | sprint 2 #306

Bahasyd wants to merge 19 commits into from

Conversation

@Bahasyd
Copy link

@Bahasyd Bahasyd commented Feb 19, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

n/a

Questions

Ask any questions you have for your reviewer.

@Bahasyd Bahasyd self-assigned this Feb 19, 2025
@Bahasyd Bahasyd added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2025
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 26, 2025
cjyuan
cjyuan reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code looks good.

The code in Sprint-2/3-mandatory-implement/2-cases.js is not correct.

I also added a few suggestions.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 26, 2025
@Bahasyd Bahasyd added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Mar 4, 2025

Changes look good. Feel free to mark this as completed.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2025
@Bahasyd Bahasyd added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

@Bahasyd Bahasyd

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bahasyd @cjyuan @illicitonion