ITPJAN|SARAAMIRI|Module-structuring-and-testing-data|sprint3|week3#359
Closed
saraamiiri wants to merge 11 commits intoCodeYourFuture:mainfrom
Closed
ITPJAN|SARAAMIRI|Module-structuring-and-testing-data|sprint3|week3#359saraamiiri wants to merge 11 commits intoCodeYourFuture:mainfrom
saraamiiri wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
saraamiiri
changed the title
saraamiiri
added
the
Needs Review
mhmdk
reviewed
Mar 17, 2025
|
|
||
| // Test for invalid card | ||
| try { | ||
| getCardValue("X♠"); |
Contributor
There was a problem hiding this comment.
if GetCardValue() didn't throw an exception, and returned a value like 10 for example, wouldn't the test still pass?
mhmdk
reviewed
Mar 17, 2025
| }); | ||
|
|
||
| // Case 3: Identify Negative Fractions: | ||
| test("Identifies Negative Proper Fraction", () => { |
Contributor
There was a problem hiding this comment.
should also have a test for negative improper fraction.
mhmdk
added
the
Reviewed
lawkunchi
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.