London | Nadarajah Sripathmanathan | Module-Structuring-and-Testing-Data | Week 3 #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I have done |Module-Structuring-and-Testing-Data | Sprint-3. Please check it. Thank you |
sripathman
added
the
Needs Review
halilibrahimcelik
approved these changes
Apr 8, 2025
halilibrahimcelik
left a comment
halilibrahimcelik
left a comment
There was a problem hiding this comment.
Looking good, you met all the criteria stated in readme files.
| if (rank === "J") return 10; | ||
| if (rank === "Q") return 10; | ||
| if (rank === "K") return 10; | ||
| return 0; // Default case (shouldn't happen with valid cards) |
There was a problem hiding this comment.
You can put J,Q,K in same if check
cjyuan
added
Complete
Contributor
|
This PR has been reviewed and it seemed you have made the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.