Skip to content

NW-ITP |Mohammed Alzaki | Module-Structuring-and-Testing-Data| Sprint2 | week4 #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mohammed-alzaki wants to merge 11 commits into from
Closed

NW-ITP |Mohammed Alzaki | Module-Structuring-and-Testing-Data| Sprint2 | week4 #390

mohammed-alzaki wants to merge 11 commits into from

Conversation

@mohammed-alzaki
Copy link

@mohammed-alzaki mohammed-alzaki commented Mar 14, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/1-key-errors/0.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/1-key-errors/1.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/1-key-errors/2.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/2-mandatory-debug/0.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/2-mandatory-debug/1.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/2-mandatory-debug/2.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/3-mandatory-implement/1-bmi.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/3-mandatory-implement/2-cases.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works fine

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/3-mandatory-implement/3-to-pounds.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works fine - my IDE showed one minor syntax consideration ; should be at the end. Also briefly summarise the code process in about 3 lines.

fearcyf
fearcyf reviewed Mar 31, 2025
View reviewed changes
Sprint-2/4-mandatory-interpret/time-format.js
Copy link

@fearcyf fearcyf Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

@fearcyf fearcyf added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Mar 31, 2025
@fearcyf fearcyf self-assigned this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fearcyf fearcyf fearcyf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fearcyf fearcyf

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohammed-alzaki @fearcyf @illicitonion