ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_1 #433

HannaOdud · 2025-03-28T18:08:02Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
[ x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x ] I have tested my changes
[ x] My changes follow the style guide
[x ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan · 2025-04-02T00:33:03Z

I shared with you some instructions to rebase your branch onto main in your Sprint-2 PR. If you have successfully rebased (and fixed) your Sprint-2 branch, can you also follow the same instructions to fix this branch?

OracPrime

There's some good code here, but also a number of errors and omissions. I think it is worth you working through the comments and correcting the highlighted errors and re-submitting.

OracPrime · 2025-04-02T14:18:55Z

Sprint-1/1-key-exercises/3-paths.js

+const lastIndexOfDot = filePath.lastIndexOf(".");
+const ext = filePath.slice(lastIndexOfDot);
+console.log(`**** The ext pert of ${filePath} is ${ext}`);
+


This is the answer this exercise is looking for as it teaches you basic string manipulation, but if you are doing this for real, use a library (you'll get to those shortly - when you have, google path.parse )

OracPrime · 2025-04-02T14:30:14Z

Sprint-1/1-key-exercises/4-random.js

 const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;
+console.log(num);
+// this variable "num" has random
+//  generated value in range from 1 to 101


You should try running this code many times and look at the values of num (you might want a for loop to make it easier)? In particular can you in your for loop log the maximum value of num that is seen? Alternatively read the documents on Math.random more carefully.

OracPrime · 2025-04-02T14:33:18Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

+    // Three functions calls in lines 4,5,10
 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-
+    // The error in line 5


You've identified the error, but haven't made a fix

OracPrime · 2025-04-02T14:38:54Z

Sprint-1/4-stretch-explore/objects.md


-What does `console` store?
+What does `console` store? 
+    // Console store object;


Can you expand further? What does this actually mean, or provide for you?

OracPrime · 2025-04-02T14:39:51Z

Sprint-1/4-stretch-explore/objects.md

+    // Console store object;
 What does the syntax `console.log` or `console.assert` mean? In particular, what does the `.` mean?
+    //'.' - allows us to use functions of console object.
+    // `console.log` and `console.assert` are calling of these functions 


No quite. console.log is the definition of the log function. console.log() is calling it. A subtle but important distinction which you'll make use of later

OracPrime · 2025-04-02T14:55:35Z

Sprint-3/3-mandatory-practice/implement/repeat.js

-function repeat() {
-    return "hellohellohello";
+function repeat(str, num) {
+    if (num == 0 ) {


You might want to check the documentation for str.repeat and consider whether all of your code is necessary

OracPrime · 2025-04-02T14:56:57Z

Sprint-3/3-mandatory-practice/implement/repeat.test.js

+    const str = "hello";
+    const count = -1;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("");


This is expecting a "" result. However the requirement is to throw an error.

Have you run this test??

Also you should give the tests sensible descriptions to help readers understand what is going on

OracPrime · 2025-04-02T15:13:53Z

Sprint-3/4-stretch-investigate/password-validator.js

+        return false;
+    } else {
+        return true;
+    }


This isn't right. You haven't got the syntax for testing regular expressions correct, so each of you search tests is returning undefined and undefined<0 is returning false, so it thinks almost anything is a valid password.

And you're also [attempting to] use case-insensitive searching. Is this what you want?

Try googling use of regex.test and see if it helps. Also be careful about hyphens in regular expressions

OracPrime · 2025-04-02T15:14:18Z

Sprint-3/4-stretch-investigate/password-validator.test.js

+//const isValidPassword = require("./password-validator");
+
+
+function passwordValidator(password) {


No! You should be using require to get the existing function in from password-validator.js. We want to separate our main code (that we want to include in our applications) from our test code (that we don't), but we definitely want to duplicate the code. Have a search for how require works in javascript

OracPrime · 2025-04-02T15:16:02Z

Sprint-3/4-stretch-investigate/password-validator.test.js

-    expect(result).toEqual(true);
-}
-);
+    expect(result).toEqual(false);


And when you run it, is it?

OracPrime

These three changes are all good - I assume you'll be doing more commits to address the other comments?

HannaOdud · 2025-04-03T21:06:33Z

These three changes are all good - I assume you'll be doing more commits to address the other comments?

Yes. I will do each sprint.

HannaOdud added 5 commits March 5, 2025 19:19

key implementation exercises

f4e9c6b

mandatory rewrite exercises

6c4cfde

mandatory practice exercises

980fac0

stretch-investigate exercises

3ee1a41

Sprint 1

c61a07a

HannaOdud added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 1, 2025

cjyuan added the 👀 Review Git label Apr 2, 2025

OracPrime added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 2, 2025

OracPrime suggested changes Apr 2, 2025

View reviewed changes

OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 2, 2025

fixes to sprint 1

6b88353

HannaOdud requested a review from OracPrime April 3, 2025 14:59

OracPrime reviewed Apr 3, 2025

View reviewed changes

HannaOdud added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Apr 9, 2025

illicitonion removed the 👀 Review Git label Aug 5, 2025

illicitonion closed this Sep 1, 2025

		//const isValidPassword = require("./password-validator");


		function passwordValidator(password) {

Uh oh!

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_1 #433

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_1 #433

Uh oh!

Conversation

HannaOdud commented Mar 28, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan commented Apr 2, 2025

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

HannaOdud commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants