Glasgow | May-2025 | Salah Ahmed | Sprint-1 #476
Conversation
…ble updates and string manipulation
avatarit
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
- Why not practice "committing files one by one, on purpose, and for a reason"?
- In VSCode, you can select which file to stage, and commit only the staged file.
See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file).
- Explanations are clearly written. I only have few suggestions and a question.
| // Line 3 is updating the value of the count variable by adding 1 to its current value. The = operator is used for assignment, meaning it takes the value on the right (count + 1) and assigns it to the variable on the left (count). | ||
| // The expression count + 1 calculates the new value, and then the = operator assigns this new value back to the count variable. | ||
| // The count variable now holds the value 1, which is the result of the initial value (0) plus 1. |
There was a problem hiding this comment.
Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.
Can you find out what one-word programming term describes the operation on line 3?
There was a problem hiding this comment.
What is the programing term for such operation?
| // The variable num represents a random integer between the values of minimum (1) and maximum (100), inclusive. | ||
| // The expression Math.random() generates a random floating-point number between 0 (inclusive) and 1 (exclusive). |
There was a problem hiding this comment.
You can also use the concise and precise interval notation to describe a range of values.
For example, we can say Math.random() returns a random number in the interval [0, 1).
| // a) There are 2 function calls in this file: | ||
| // 1. `carPrice.replaceAll(",", "")` on line 4 | ||
| // 2. `priceAfterOneYear.replaceAll(",", "")` on line 5 |
There was a problem hiding this comment.
There are more than 2 function calls.
There was a problem hiding this comment.
Yes, I have added the 3rd function
There was a problem hiding this comment.
There are more then 3 function calls.
I could not see any new changes made to the file Sprint-1/3-mandatory-interpret/1-percentage-change.js.
| // .substring(paddedPenceNumberString.length - 2).padEnd(2, "0"): | ||
| // extracts the last two characters (the pence part) and pads it with trailing zeros to ensure it has 2 characters, resulting in "99" |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
There was a problem hiding this comment.
I have refactored the code for improved readability and remove unnecessary padding logic
const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2);
No need to padEnd here since paddedPenceNumberString always has at least 3 digits
There was a problem hiding this comment.
Your understanding is correct. Change is not needed. The task only asks you to describe how the code works.
cjyuan
added
Reviewed
avatarit
added
Needs Review
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
I have solved all issues in sprint 1