ZA | ITP-May-2025 | Revive Munashe Mapfumo | Coursework/Sprint-1 #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivakutu
added
the
Needs Review
rivakutu
changed the title
rivakutu
changed the title
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| // line 4 has a function call Number(carPrice.replaceAll(",", "")) | ||
| //line 5 has a function call Number(priceAfterOneYear.replaceAll(",","")) |
There was a problem hiding this comment.
You are missing a function call.
| // For the piece of code above, read the code and then answer the following questions | ||
|
|
||
| // a) How many variable declarations are there in this program? | ||
| // there are 4 variable declarations in this program |
Author
There was a problem hiding this comment.
added more variable declarations
| // there are 4 variable declarations in this program | ||
|
|
||
| // b) How many function calls are there? | ||
| // there 0 function calls in this program |
Waldo-Strydom
added
👀 Review Requirements
Reviewed
Author
|
I've made adjustments according to your specifications. Thanks |
Author
|
Good day to you. Anything i need to change on my files? |
|
Well done |
Waldo-Strydom
added
Complete
Author
|
Thank you Waldo
…On Sat, 28 Jun 2025, 17:20 Waldo Strydom, ***@***.***> wrote:
*Waldo-Strydom* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#490)
<#490 (comment)>
Well done
—
Reply to this email directly, view it on GitHub
<#490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BM7V7JLQYYLABHAP7MECQZL3F2XDLAVCNFSM6AAAAAB6Z7JZ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJVGQ3TCMBTGU>
.
You are receiving this because you authored the thread.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/490/c3015471035@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Refined logic and documentation for penceToPoundsConverter to clarify conversion details.
Improved increment operations by adding explanations and adjustments to variable handling.
Defined and structured variables such as dir and ext for better readability.
Enhanced console output by logging calculated initials and generated random numbers.
Fixed syntax and variable reassignment issues, including hoisting-related bugs.
Resolved slicing errors in cardNumber to prevent TypeError.
Updated comments and documentation to clarify variable declarations, functions, and built-in method effects.
Addressed naming inconsistencies and scope adjustments for better maintainability.
Questions
Ask any questions you have for your reviewer.