-
-
Notifications
You must be signed in to change notification settings - Fork 301
London|May-2025|Alexandru Pocovnicu|Coursework|sprint 1 #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
London|May-2025|Alexandru Pocovnicu|Coursework|sprint 1 #494
Conversation
…bout what 'num' is
Sprint-1/1-key-exercises/3-paths.js
Outdated
| const dir = filePath.slice(1,4); | ||
| const ext = filePath.slice(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked the variables to see if they hold the expected values?
Can you think of a solution that could work for any valid file path?
For examples, "/tmp/package.json", "/Sprint-1/1-key-exercises/2-initials.js"
| 0, | ||
| paddedPenceNumberString.length - 2 | ||
| );:it creates a string variable with the value of '3' | ||
| 17-19. it creates a string variable that has the value of the last 2 characters from '399' which is '99' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this script we don't need it , padStart(3,0) takes care of that
| What output do you get?---ƒ log() { [native code] } | ||
|
|
||
| Now enter just `console` in the Console, what output do you get back? | ||
| Now enter just `console` in the Console, what output do you get back?---- a drop down list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you press "Enter" key after typing console?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , but i didn't copy pasted, I missunderstood the question,I reviewed my answer now
|
Changes look good! Well done. |
|
thank you |
Learners, PR Template
Self checklist
Changelist
I have completed sprint 1, which included exercises, errors, interpreting code, and exploring chrome console
Questions
Ask any questions you have for your reviewer.