Skip to content

Conversation

@alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Jun 8, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I have completed sprint 1, which included exercises, errors, interpreting code, and exploring chrome console

Questions

Ask any questions you have for your reviewer.

@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2025
Comment on lines 20 to 21
const dir = filePath.slice(1,4);
const ext = filePath.slice(-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the variables to see if they hold the expected values?

Can you think of a solution that could work for any valid file path?
For examples, "/tmp/package.json", "/Sprint-1/1-key-exercises/2-initials.js"

0,
paddedPenceNumberString.length - 2
);:it creates a string variable with the value of '3'
17-19. it creates a string variable that has the value of the last 2 characters from '399' which is '99'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this script we don't need it , padStart(3,0) takes care of that

What output do you get?---ƒ log() { [native code] }

Now enter just `console` in the Console, what output do you get back?
Now enter just `console` in the Console, what output do you get back?---- a drop down list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you press "Enter" key after typing console?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , but i didn't copy pasted, I missunderstood the question,I reviewed my answer now

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 19, 2025
@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 24, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 25, 2025

Changes look good! Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 25, 2025
@alexandru-pocovnicu
Copy link
Author

thank you

@illicitonion illicitonion changed the title London|May-2025|Alexandru Pocovnicu|Coursework/sprint 1 London|May-2025|Alexandru Pocovnicu|Coursework|sprint 1 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants