ITP-May-25|NW | Rahwa Zeslus| Module-Structuring-and-Testing-Data | Week3 #500
Conversation
…racter occurrences
…ers with test cases that handle the edge cases
RahwaZeslusHaile
added
the
Needs Review
|
Note: if you first change to the This makes it easier to review as it's only the relevant changes 🙂 |
CameronDowner
added
Review in progress
| @@ -10,7 +10,16 @@ | |||
| function getAngleType(angle) { | |||
There was a problem hiding this comment.
What would you expect to see from this?
getAngleType("45");There was a problem hiding this comment.
I expect an error because "45" is a string not a number.I refactor the code to convert the parameter to number datatype and I use switch(true),just to stretch my self
|
|
||
| if(rank === "A") return 11; | ||
| if (["J","Q","K"].includes(rank)) return 10; | ||
| if(!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 10 ) return Number(rank); |
There was a problem hiding this comment.
Is there a way to simplify this if statement?
e.g. could we extract a common variable, do we need all 3 conditions?
| if(angle > 90 && angle < 180) return "Obtuse angle" | ||
| if(angle === 180) return "Straight angle" | ||
| if(angle > 180 && angle < 360) return "Reflex angle" | ||
| if (typeof angle !== 'number' || angle < 0 || angle >= 360) return "Invalid angle"; |
There was a problem hiding this comment.
Could moving this validation if statement to the top help simplify our function?
There was a problem hiding this comment.
One thing I like to remember: code is read by the computer, but also by other people.
You're getting on great with these courseworks, so I think you should start considering: can I make this code easier to read for other people?
|
|
||
| // Case 3: Identify Negative Fractions: | ||
| test("should return true for a proper fraction with one of the value negative ", () => { | ||
| expect(isProperFraction(-2, 3)).toEqual(true); |
There was a problem hiding this comment.
Jest also has .toBeTruthy(): https://jestjs.io/docs/expect#tobetruthy
Why might that not be a good thing to use here?
CameronDowner
added
Complete
|
@CameronDowner Thank you so much for taking the time to review my code. I truly appreciate your thoughtful feedback — it helped me spot things I had overlooked ,your insights are incredibly valuable to my learning, and I’m grateful for your support and encouragement. |
illicitonion
deleted the branch
CodeYourFuture:to-be-deleted-coursework/sprint-3
4 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.
Thank you for your time in reviewing this work