London|May_2025|Fatma_Degirmenci|Structuring_and_Testing_Data|Sprint1

[fatmaevin]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

• I read the explanations in Sprint 1 and did the necessary research to learn about JavaScript operators, variable declarations, and various methods like floor and slice. Then I practiced by making some changes in the code.

[cjyuan]

1. Why not practice "committing files one by one, on purpose, and for a reason"?
   In VSCode, you can select which file to stage, and commit only the staged file.
   See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file).

2. When describing code, we should avoid simply translating it literally because:

• Other developers can already read the code and see what it does.
• A literal description adds no extra insight to help others understand the purpose, logic, or context of the code.

Here is an example of a literal translation of a piece of code:

   // if num mod 2 is 0
   if (num % 2 == 0)
     ...

A better description would be "if num is even".

Describing code can be quite challenging at first (even in your native language). I suggest using ChatGPT to explore alternative ways to describe the code. Along the way, you might also pick up some useful programming terminology.

[cjyuan]

Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?

[cjyuan]

Leaving responses directly in the comment threads makes tracking the discussion easier.

Here is a simplified version of best practices ChatGPT suggested for responding to inline comments in a pull request:

• ✅ Reply to every comment – Let the reviewer know you saw it.
• ✏️ Make the change if needed – Fix the code if the comment points out a real issue.
• 🤔 Explain if you don't agree – If you think the code is fine, politely explain why.
• ✅ Mark as resolved when done – Only mark comments resolved after you fix or respond.
• 💬 Keep replies short and polite – Be respectful and to the point.
• ⏱️ Respond soon – Don’t wait too long to reply.
• 🧪 Test your changes – Make sure your fixes actually work.
• 📍 Reply directly under the comment – This keeps the conversation easy to follow.

You can try the approach in future PRs.

[cjyuan]

Have you tried executing the script without padEnd(2, "0") using different values of penceString to validate your expectation?

[fatmaevin]

Thanks for the feedback. I just tested the script with various penceString values without the .padEnd(2, "0") part.
It works correctly in all cases because .padStart(3, "0") already adds leading zeros when needed, ensuring the pence part always has two digits—I realized this just now.
So, .padEnd(2, "0") is actually unnecessary.
I will update the comment to reflect this and remove the misleading explanation.

[cjyuan]

Great job!