West Midlands | May-2025 | Mustaf Asani | Sprint-1 #510
Conversation
asaniDev
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is good and explanation is clear. Well done.
I only have a few suggestions and comments.
| // 2. const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1): removes the trailing 'p' from the string by using the substring method and passing it the start index (0) and the end index (length - 1) returning "399". | ||
| // 3. const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"): pads the string with leading zeros to ensure it has at least 3 characters, resulting in "399" remaining unchanged. | ||
| // 4. const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2): extracts the pounds part of the string by taking all characters except the last two, resulting in "3". | ||
| // 5. const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"): extracts the last two characters of the string and pads it with trailing zeros if necessary, resulting in "99" since it already has two characters. |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
cjyuan
added
Reviewed
asaniDev
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
A commit with the message "updating to remote" have changed all the files in your branch (which also affected your Sprint-2 branches). You probably did not setup CRLF conversion properly.
You could fix the problem via
- Git commands (Ask ChatGPT
what should i do if my previous push to GitHub did not convert the CR/LF properly?), or - Create a new branch from your
mainbranch, then transfer your files to the new branch, and commit the files in the proper folders.
If you choose option (2), you can also practice committing files one by one, on purpose, and for a reason. In VSCode, you can select which file to stage, and commit only the staged file. See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file).
Please fix the branch. You should also do the same for your Sprint-2 branch.
To find out what is the best practices, you can ask ChatGPT,
|
cjyuan
added
👀 Review Git
and removed
Needs Review
4 participants
Learners, PR Template
Self checklist
Changelist
Completed all the tasks in sprint 1
Questions
Ask any questions you have for your reviewer.